Re: [HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-28 Thread Andrew Dunstan
On 02/27/2016 01:24 PM, John Gorman wrote: On Sat, Feb 27, 2016 at 9:25 AM, Robert Haas > wrote: On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan mailto:and...@dunslane.net>> wrote: > Perhaps what we need to do is modify pg_regress.c slightly to

Re: [HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread John Gorman
On Sat, Feb 27, 2016 at 9:25 AM, Robert Haas wrote: > On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan > wrote: > > > Perhaps what we need to do is modify pg_regress.c slightly to allow more > > than one --temp-config argument. But that could be done later. > > Well, I'm pretty interested in usin

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Robert Haas
On Sat, Feb 27, 2016 at 8:36 PM, Andrew Dunstan wrote: > "doesn't meet your need" is probably a better way of putting it. The > facility's use has grown beyond what I originally envisaged, so I think we > will need that patch. > > Would you like me to apply what I have? Go for it. -- Robert Haa

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Andrew Dunstan
On 02/27/2016 09:25 AM, Robert Haas wrote: On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan wrote: What I had in mind was something like the attached. In testing this seems to do the right thing, and the nice part is that it will be picked up by the buildfarm in the one case that's relevant,

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Robert Haas
On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan wrote: > What I had in mind was something like the attached. > > In testing this seems to do the right thing, and the nice part is that it > will be picked up by the buildfarm in the one case that's relevant, namely > the ecpg tests. > > The only fly

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Andrew Dunstan
On 02/26/2016 10:59 PM, Robert Haas wrote: On Sat, Feb 27, 2016 at 9:00 AM, Andrew Dunstan wrote: Sure. Saving three lines of Makefile duplication is hardly a world-shattering event, so I thought there might be some other purpose. But I'm not against saving three lines of duplication either

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-26 Thread Robert Haas
On Sat, Feb 27, 2016 at 9:00 AM, Andrew Dunstan wrote: >> Sure. Saving three lines of Makefile duplication is hardly a >> world-shattering event, so I thought there might be some other >> purpose. But I'm not against saving three lines of duplication >> either, if it won't break anything. > The