Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-04-12 Thread Tom Lane
I wrote: Silent allow is fine with me, I was just wondering if anyone liked the other options better. Okay, I'm back on the warpath about this after noting yet another user who thinks he should use -i mindlessly: http://archives.postgresql.org/pgsql-admin/2008-04/msg00111.php I believe the

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-04-12 Thread Joshua D. Drake
Tom Lane wrote: I believe the consensus was * pg_dump and pg_restore should continue to accept -i/--ignore-version options, to avoid needlessly breaking existing scripts, but these switches will become no-ops; the version check will occur anyway. * pg_dump should be fixed to allow server

[HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Bruce Momjian
Tom Lane wrote: [EMAIL PROTECTED] (Bruce Momjian) writes: Log Message: --- Strengthen warnings about using pg_dump's -i option. The proposed TODO item was not about doing this, it was about removing the option altogether. AFAICS it's a foot-gun and nothing else --- why do we

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: [EMAIL PROTECTED] (Bruce Momjian) writes: Strengthen warnings about using pg_dump's -i option. The proposed TODO item was not about doing this, it was about removing the option altogether. AFAICS it's a foot-gun and nothing else ---

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: [EMAIL PROTECTED] (Bruce Momjian) writes: Strengthen warnings about using pg_dump's -i option. The proposed TODO item was not about doing this, it was about removing the option altogether. AFAICS it's a foot-gun

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: My proposal would be to continue to accept the option but just ignore it (ie, error out on version mismatch whether or not -i is given). This way we wouldn't break any scripts that use the option, but things would still be safe. A

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: My proposal would be to continue to accept the option but just ignore it (ie, error out on version mismatch whether or not -i is given). This way we wouldn't break any scripts that use the option, but things would

Re: [HACKERS] Re: [COMMITTERS] pgsql: Strengthen warnings about using pg_dump's -i option.

2008-03-26 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: Tom Lane wrote: One point after looking back at the previous discussion is that the current version test is too strict: it will complain if your server is 8.2.7 and pg_dump is 8.2.6. We probably should not make a newer minor number a hard error, since