Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Peter Eisentraut wrote: > On 9/4/17 06:03, Alvaro Herrera wrote: > > Tom Lane wrote: > >> Michael Paquier writes: > >>> I don't like breaking the abstraction of pg_log() with the existing > >>> flags with some kind of pg_debug() layer. The set of APIs present now > >>>

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Peter Eisentraut wrote: > On 9/4/17 06:03, Alvaro Herrera wrote: > > Tom Lane wrote: > >> Michael Paquier writes: > >>> I don't like breaking the abstraction of pg_log() with the existing > >>> flags with some kind of pg_debug() layer. The set of APIs present now > >>>

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Thu, Sep 7, 2017 at 10:11 AM, Peter Eisentraut wrote: > On 9/4/17 06:03, Alvaro Herrera wrote: >> Tom Lane wrote: >>> Michael Paquier writes: I don't like breaking the abstraction of pg_log() with the existing flags with

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On 9/4/17 06:03, Alvaro Herrera wrote: > Tom Lane wrote: >> Michael Paquier writes: >>> I don't like breaking the abstraction of pg_log() with the existing >>> flags with some kind of pg_debug() layer. The set of APIs present now >>> in pg_rewind for logging is nice to

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Tom Lane wrote: > Michael Paquier writes: > > I don't like breaking the abstraction of pg_log() with the existing > > flags with some kind of pg_debug() layer. The set of APIs present now > > in pg_rewind for logging is nice to have, and I think that those debug > >

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Thu, Aug 31, 2017 at 8:39 AM, Alvaro Herrera wrote: > Michael Paquier wrote: >> So, perhaps it would be better to fix that before the next point release? > > Sure, I'll get it done on Friday, or tomorrow if I can manage it. Thanks, Álvaro. -- Michael -- Sent via

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Michael Paquier wrote: > On Tue, Aug 29, 2017 at 11:26 AM, Tom Lane wrote: > > Michael Paquier writes: > >> I don't like breaking the abstraction of pg_log() with the existing > >> flags with some kind of pg_debug() layer. The set of APIs present

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Tue, Aug 29, 2017 at 11:26 AM, Tom Lane wrote: > Michael Paquier writes: >> I don't like breaking the abstraction of pg_log() with the existing >> flags with some kind of pg_debug() layer. The set of APIs present now >> in pg_rewind for logging

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Michael Paquier writes: > I don't like breaking the abstraction of pg_log() with the existing > flags with some kind of pg_debug() layer. The set of APIs present now > in pg_rewind for logging is nice to have, and I think that those debug > messages should be

Re: [HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Mon, Aug 28, 2017 at 11:24 PM, Robert Haas wrote: > On Mon, Aug 28, 2017 at 10:16 AM, Alvaro Herrera > wrote: >>> I am fine with however you want to handle it, but it seems odd to me >>> that we don't have a way of embedding INT64_FORMAT in a

[HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Mon, Aug 28, 2017 at 10:16 AM, Alvaro Herrera wrote: >> I am fine with however you want to handle it, but it seems odd to me >> that we don't have a way of embedding INT64_FORMAT in a translatable >> string. Surely that's going to be a problem in some case, sometime,

[HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Robert Haas wrote: > On Mon, Aug 28, 2017 at 9:05 AM, Alvaro Herrera > wrote: > > Robert Haas wrote: > >> pg_rewind: Fix some problems when copying files >2GB. > > > > I just noticed that this broke pg_rewind translation, because of the > > INT64_FORMAT marker in the

[HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

On Mon, Aug 28, 2017 at 9:05 AM, Alvaro Herrera wrote: > Robert Haas wrote: >> pg_rewind: Fix some problems when copying files >2GB. > > I just noticed that this broke pg_rewind translation, because of the > INT64_FORMAT marker in the translatable string. The message

[HACKERS] Re: [COMMITTERS] pgsql: pg_rewind: Fix some problems when copying files >2GB.

Robert Haas wrote: > pg_rewind: Fix some problems when copying files >2GB. I just noticed that this broke pg_rewind translation, because of the INT64_FORMAT marker in the translatable string. The message catalog now has this: msgid "received chunk for file \"%s\", offset " for this source