[HACKERS] Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests

2016-12-07 Thread Aleksander Alekseev
Hello, Craig. I noticed that these patches have a "Needs review" status and decided to take a look. Surprisingly I didn't manage to find many defects. * I like this idea in general; * Code is test covered and documented well; * All tests pass; * No warnings during compilation and/or tests run; *

[HACKERS] Re: [PATCH] PostgresNode.pm enhancements, pg_lsn helper, and some more recovery tests

2016-11-13 Thread Craig Ringer
On 14 November 2016 at 15:01, Craig Ringer wrote: > These three are related enough, and all only touch the TAP framework, > so I've bundled them in a series. CF entry https://commitfest.postgresql.org/12/883/ -- Craig Ringer