[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-10-30 Thread Alvaro Herrera
Andres Freund escribió: > On Monday, October 29, 2012 08:58:53 PM Alvaro Herrera wrote: > > Heikki Linnakangas escribió: > > Andres commented elsewhere about reading xlog records, processing them > > as they came in, and do a running CRC while we're still reading it. I > > think this is a mistake

Re: [HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-10-29 Thread Tom Lane
Alvaro Herrera writes: > I think you may have converted some malloc() calls from Andres' patch > into palloc() -- because you have some palloc() calls which are later > checked for NULL results, which obviously doesn't make sense. At the > same time, if we're going to use malloc() instead of pall

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-10-29 Thread Alvaro Herrera
Heikki Linnakangas escribió: > Hmm. I was thinking that making this work in a non-backend context > would be too hard, so I didn't give that much thought, but I guess > there isn't many dependencies to backend functions after all. > palloc/pfree are straightforward to replace with malloc/free. Tha

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-10-18 Thread Alvaro Herrera
This patch doesn't seem to be going anywhere, sadly. Since we're a bit late in the commitfest and this patch hasn't seen any activity for a long time, I'll mark it as returned-with-feedback. I hope one or both versions are resubmitted (with additional fixes?) for the next commitfest, and that the

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-09-17 Thread Heikki Linnakangas
On 17.09.2012 14:42, Andres Freund wrote: On Monday, September 17, 2012 12:55:47 PM Heikki Linnakangas wrote: On 17.09.2012 13:01, Andres Freund wrote: On Monday, September 17, 2012 11:07:28 AM Andres Freund wrote: On Monday, September 17, 2012 10:30:35 AM Heikki Linnakangas wrote: On 17.09.2

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-09-17 Thread Heikki Linnakangas
On 17.09.2012 12:07, Andres Freund wrote: On Monday, September 17, 2012 10:30:35 AM Heikki Linnakangas wrote: The user of the facility doesn't need to be aware of record boundaries, that's the responsibility of the facility. I thought that's exactly the point of generalizing this thing, to make

[HACKERS] Re: [PATCH 3/8] Add support for a generic wal reading facility dubbed XLogReader

2012-09-17 Thread Heikki Linnakangas
On 17.09.2012 11:12, Andres Freund wrote: On Monday, September 17, 2012 09:40:17 AM Heikki Linnakangas wrote: On 15.09.2012 03:39, Andres Freund wrote: 2. We should focus on reading WAL, I don't see the point of mixing WAL writing into this. If you write something that filters/analyzes and then