Re: [HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-06-23 Thread Tom Lane
Heikki Linnakangas writes: > Earlier in this thread, MauMau pointed out that we can't do encoding > conversions until we have connected to the database because you need to > read pg_conversion for that. That's because we support creating custom > conversions with CREATE CONVERSION. Frankly, I d

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-06-23 Thread Heikki Linnakangas
On 04/05/2014 07:56 AM, Tom Lane wrote: "MauMau" writes: Then, as a happy medium, how about disabling message localization only if the client encoding differs from the server one? That is, compare the client_encoding value in the startup packet with the result of GetPlatformEncoding(). If the

Re: [HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-01-10 Thread Noah Misch
On Fri, Jan 10, 2014 at 08:03:00PM -0500, Tom Lane wrote: > Noah Misch writes: > >> On Sun, Jan 5, 2014 at 04:40:17PM +0900, MauMau wrote: > >>> Then, as a happy medium, how about disabling message localization > >>> only if the client encoding differs from the server one? That is, > >>> compare

Re: [HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-01-10 Thread Tom Lane
Noah Misch writes: >> On Sun, Jan 5, 2014 at 04:40:17PM +0900, MauMau wrote: >>> Then, as a happy medium, how about disabling message localization >>> only if the client encoding differs from the server one? That is, >>> compare the client_encoding value in the startup packet with the >>> result

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-01-10 Thread Noah Misch
On Tue, Jan 07, 2014 at 10:56:28PM +0900, MauMau wrote: > From: "Bruce Momjian" > >On Sun, Jan 5, 2014 at 04:40:17PM +0900, MauMau wrote: > >>Then, as a happy medium, how about disabling message localization > >>only if the client encoding differs from the server one? That is, > >>compare the cl

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2014-01-06 Thread Bruce Momjian
On Sun, Jan 5, 2014 at 04:40:17PM +0900, MauMau wrote: > From: "Noah Misch" > >I agree that English consistently beats mojibake. I question whether that > >makes up for the loss of translation when encodings do happen to match, > >particularly for non-technical errors like a mistyped password.

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-29 Thread Noah Misch
On Sun, Dec 22, 2013 at 07:51:55PM +0900, MauMau wrote: > From: "Noah Misch" > >Better to attack that directly. Arrange to apply any > >client_encoding named in > >the startup packet earlier, before authentication. This relates > >to the TODO > >item "Let the client indicate character encoding o

Re: [HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-20 Thread Alvaro Herrera
Noah Misch escribió: > On Tue, Dec 17, 2013 at 01:42:08PM -0500, Bruce Momjian wrote: > > On Fri, Dec 13, 2013 at 10:41:17PM +0900, MauMau wrote: > > > [Fix] > > > Disable message localization during session startup. In other > > > words, messages are output in English until the database session

[HACKERS] Re: [bug fix] multibyte messages are displayed incorrectly on the client

2013-12-19 Thread Noah Misch
On Tue, Dec 17, 2013 at 01:42:08PM -0500, Bruce Momjian wrote: > On Fri, Dec 13, 2013 at 10:41:17PM +0900, MauMau wrote: > > [Cause] > > While the session is being established, the server cannot use the > > client encoding for message conversion yet, because it cannot access > > system catalogs to