Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-25 Thread Peter Geoghegan
On Tue, Aug 22, 2017 at 4:58 AM, Daniel Verite wrote: > For the record, attached are the collname that initdb now creates > in pg_collation, when compiled successively with all current > versions of ICU (49 to 59), versus what 10beta2 did. > > There are still a few names that get dropped along the

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-21 Thread Peter Geoghegan
On Mon, Aug 21, 2017 at 4:48 PM, Peter Eisentraut wrote: > On 8/21/17 12:33, Peter Geoghegan wrote: >> On Mon, Aug 21, 2017 at 8:23 AM, Peter Eisentraut >> wrote: >>> Here are my patches to address this. >> >> These look good. > > Committed. That closes this open item. Thanks again. -- Peter

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-21 Thread Peter Eisentraut
On 8/21/17 12:33, Peter Geoghegan wrote: > On Mon, Aug 21, 2017 at 8:23 AM, Peter Eisentraut > wrote: >> Here are my patches to address this. > > These look good. Committed. That closes this open item. > One small piece of feedback: I suggest naming the custom collation > "numeric" something e

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-21 Thread Peter Geoghegan
On Mon, Aug 21, 2017 at 9:33 AM, Peter Geoghegan wrote: > On Mon, Aug 21, 2017 at 8:23 AM, Peter Eisentraut > wrote: >> Here are my patches to address this. > > These look good. Also, I don't know why en-u-kr-others-digit wasn't accepted by CREATE COLLATION, as you said on the other thread just

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-21 Thread Peter Geoghegan
On Mon, Aug 21, 2017 at 8:23 AM, Peter Eisentraut wrote: > Here are my patches to address this. These look good. One small piece of feedback: I suggest naming the custom collation "numeric" something else instead: "natural". Apparently, the behavior it implements is sometimes called natural sort

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-21 Thread Peter Eisentraut
On 8/19/17 19:15, Peter Geoghegan wrote: > Noah Misch wrote: >> I think you're contending that, as formulated, this is not a valid v10 open >> item. Are you? > > As the person that came up with this formulation, I'd like to give a > quick summary of my current understanding of the item's status:

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-19 Thread Peter Geoghegan
Noah Misch wrote: I think you're contending that, as formulated, this is not a valid v10 open item. Are you? As the person that came up with this formulation, I'd like to give a quick summary of my current understanding of the item's status: * We're in agreement that we ought to have initdb

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-18 Thread Peter Eisentraut
On 8/17/17 23:13, Noah Misch wrote: >> I haven't read anything since that has provided any more clarity about >> what needs changing here. I will entertain concrete proposals about the >> specific points above (considering any other issues under discussion to >> be PG11 material), but in the absen

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-17 Thread Noah Misch
On Thu, Aug 17, 2017 at 09:22:07PM -0400, Peter Eisentraut wrote: > On 8/14/17 12:23, Peter Eisentraut wrote: > > On 8/13/17 15:39, Noah Misch wrote: > >> This PostgreSQL 10 open item is past due for your status update. Kindly > >> send > >> a status update within 24 hours, and include a date for

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-17 Thread Peter Eisentraut
On 8/14/17 12:23, Peter Eisentraut wrote: > On 8/13/17 15:39, Noah Misch wrote: >> This PostgreSQL 10 open item is past due for your status update. Kindly send >> a status update within 24 hours, and include a date for your subsequent >> status >> update. Refer to the policy on open item ownersh

Re: [HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-14 Thread Peter Eisentraut
On 8/13/17 15:39, Noah Misch wrote: > This PostgreSQL 10 open item is past due for your status update. Kindly send > a status update within 24 hours, and include a date for your subsequent status > update. Refer to the policy on open item ownership: > https://www.postgresql.org/message-id/2017040

[HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-13 Thread Noah Misch
On Thu, Aug 10, 2017 at 04:51:16AM +, Noah Misch wrote: > On Mon, Aug 07, 2017 at 06:23:56PM -0400, Tom Lane wrote: > > Peter Eisentraut writes: > > > On 8/6/17 20:07, Peter Geoghegan wrote: > > >> I've looked into this. I'll give an example of what keyword variants > > >> there are for Greek,

[HACKERS] Re: ICU collation variant keywords and pg_collation entries (Was: [BUGS] Crash report for some ICU-52 (debian8) COLLATE and work_mem values)

2017-08-09 Thread Noah Misch
On Mon, Aug 07, 2017 at 06:23:56PM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 8/6/17 20:07, Peter Geoghegan wrote: > >> I've looked into this. I'll give an example of what keyword variants > >> there are for Greek, and then discuss what I think each is. > > > I'm not sure why we wan