Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread David G. Johnston
On Tue, Sep 19, 2017 at 11:29 AM, Tom Lane wrote: > ​T​ > hat > ​ ​ > doesn't work today, and this patch doesn't fix it, but it does create > enough confusion that we never would be able to fix it. > > I'd be much happier if there were some notational difference > between I-want-the-composite-var

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Tom Lane
"David G. Johnston" writes: > On Tue, Sep 19, 2017 at 2:12 PM, Tom Lane wrote: >> Notice the parens/comma positioning. It's only because text is such >> a lax datatype that you didn't notice the problem. > I saw exactly what you described - that it didn't error out and that the > text represent

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread David G. Johnston
On Tue, Sep 19, 2017 at 2:12 PM, Tom Lane wrote: > "David G. Johnston" writes: > > Actually, this does work, just not the way one would immediately expect. > > On closer inspection, what's actually happening in your example is that > you're getting the SELECT's ct1 result crammed into the first

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Tom Lane
"David G. Johnston" writes: > Actually, this does work, just not the way one would immediately expect. On closer inspection, what's actually happening in your example is that you're getting the SELECT's ct1 result crammed into the first column of c1, and then a default NULL is stuck into its seco

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Tom Lane
"David G. Johnston" writes: >> Aside from being inconsistent, it doesn't cover all >> the cases --- what if you have just one query output column, that is >> composite, and you'd like it to go into a composite variable? That >> doesn't work today, and this patch doesn't fix it, but it does create

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread David G. Johnston
On Tue, Sep 19, 2017 at 11:29 AM, Tom Lane wrote: > Aside from being inconsistent, it doesn't cover all > the cases --- what if you have just one query output column, that is > composite, and you'd like it to go into a composite variable? That > doesn't work today, and this patch doesn't fix it,

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Pavel Stehule
2017-09-19 20:29 GMT+02:00 Tom Lane : > Pavel Stehule writes: > > 2017-09-14 12:33 GMT+02:00 Anthony Bykov : > >> As far as I understand, this patch adds functionality (correct me if I'm > >> wrong) for users. Shouldn't there be any changes in doc/src/sgml/ with > the > >> description of new func

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Tom Lane
Pavel Stehule writes: > 2017-09-14 12:33 GMT+02:00 Anthony Bykov : >> As far as I understand, this patch adds functionality (correct me if I'm >> wrong) for users. Shouldn't there be any changes in doc/src/sgml/ with the >> description of new functionality? > It removes undocumented limit. I rech

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Pavel Stehule
2017-09-19 11:43 GMT+02:00 Anthony Bykov : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:tested, passed > > Hell

[HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-19 Thread Anthony Bykov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hello, I've tested it (make check-world) and as far as I unde

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-14 Thread Pavel Stehule
Hi 2017-09-14 12:33 GMT+02:00 Anthony Bykov : > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: not tested > Documentation:tested, failed > > Hell

[HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-14 Thread Anthony Bykov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation:tested, failed Hello, As far as I understand, this patch adds functionality (cor

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-12 Thread Pavel Stehule
Hi I am sending rebased patch Regards Pavel diff --git a/src/pl/plpgsql/src/pl_gram.y b/src/pl/plpgsql/src/pl_gram.y index 94f1f58593..4b6bf0b5bc 100644 --- a/src/pl/plpgsql/src/pl_gram.y +++ b/src/pl/plpgsql/src/pl_gram.y @@ -92,9 +92,10 @@ static char *NameOfDatum(PLwdatum *wdatum); static

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-07 Thread Pavel Stehule
2017-09-07 19:48 GMT+02:00 Pavel Stehule : > > > 2017-09-07 8:08 GMT+02:00 Anthony Bykov : > >> The following review has been posted through the commitfest application: >> make installcheck-world: not tested >> Implements feature: not tested >> Spec compliant: not tested >> Docume

Re: [HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-07 Thread Pavel Stehule
2017-09-07 8:08 GMT+02:00 Anthony Bykov : > The following review has been posted through the commitfest application: > make installcheck-world: not tested > Implements feature: not tested > Spec compliant: not tested > Documentation:not tested > > I'm afraid this patch

[HACKERS] Re: issue: record or row variable cannot be part of multiple-item INTO list

2017-09-06 Thread Anthony Bykov
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested I'm afraid this patch conflicts with current master branch. The new status