Re: [HACKERS] Regression tests failing if not launched on db regression

2014-02-03 Thread Robert Haas
On Fri, Jan 31, 2014 at 5:48 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Feb 1, 2014 at 12:42 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 31, 2014 at 2:28 AM, Michael Paquier michael.paqu...@gmail.com wrote: I took a look at this with a view to committing it but

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-02-03 Thread Michael Paquier
On Tue, Feb 4, 2014 at 12:49 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 31, 2014 at 5:48 PM, Michael Paquier michael.paqu...@gmail.com wrote: The part about the planning parameter looks good, thanks. The places used to mention the databases used also makes more sense. Thanks for

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-01-31 Thread Robert Haas
On Fri, Jan 31, 2014 at 2:28 AM, Michael Paquier michael.paqu...@gmail.com wrote: I took a look at this with a view to committing it but on examination I'm not sure this is the best way to proceed. The proposed text documents that the tests should be run in a database called regression, but

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-01-31 Thread Michael Paquier
On Sat, Feb 1, 2014 at 12:42 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 31, 2014 at 2:28 AM, Michael Paquier michael.paqu...@gmail.com wrote: I took a look at this with a view to committing it but on examination I'm not sure this is the best way to proceed. The proposed text

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-01-30 Thread Christian Kruse
Hi, For the documentation patch, I propose the attached to avoid future confusions. Comments? It might make sense to back-patch as well. Compiles, didn't find any typos and I think it is comprehensible. Looks fine for me. Best regards, -- Christian Kruse

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-01-30 Thread Robert Haas
On Thu, Jan 30, 2014 at 3:32 AM, Christian Kruse christ...@2ndquadrant.com wrote: For the documentation patch, I propose the attached to avoid future confusions. Comments? It might make sense to back-patch as well. Compiles, didn't find any typos and I think it is comprehensible. I took a

Re: [HACKERS] Regression tests failing if not launched on db regression

2014-01-30 Thread Michael Paquier
On Fri, Jan 31, 2014 at 6:09 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jan 30, 2014 at 3:32 AM, Christian Kruse christ...@2ndquadrant.com wrote: For the documentation patch, I propose the attached to avoid future confusions. Comments? It might make sense to back-patch as well.

[HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Michael Paquier
Hi all, It happens that the following regression tests are failing if they are run on a database not named regression: - updatable_views - foreign_data - sequence Those tests are failing because some relations of information_schemas contain information that are database-dependent. Please see the

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Michael Paquier
On Thu, Dec 5, 2013 at 5:12 PM, Michael Paquier michael.paqu...@gmail.com wrote: Those tests are failing because some relations of information_schemas contain information that are database-dependent. I forgot to mention that it is our QE team at VMware that reported me a portion of this failure,

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: It happens that the following regression tests are failing if they are run on a database not named regression: This does not seem like a bug to me, although maybe we'd better update the documentation to specify that you need to use a DB named

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Robert Haas
On Thu, Dec 5, 2013 at 9:24 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: It happens that the following regression tests are failing if they are run on a database not named regression: This does not seem like a bug to me, although maybe we'd better

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Dec 5, 2013 at 9:24 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: It happens that the following regression tests are failing if they are run on a database not named regression: This does not seem

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Michael Paquier
On 2013/12/06, at 3:52, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Dec 5, 2013 at 9:24 AM, Tom Lane t...@sss.pgh.pa.us wrote: Michael Paquier michael.paqu...@gmail.com writes: It happens that the following regression tests are failing if they

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Peter Eisentraut
On Thu, 2013-12-05 at 17:12 +0900, Michael Paquier wrote: IMHO, the regression test suite would gain in consistency and portability if we do not refer to data that is database-dependent. I once did some similar fixes (e3d9dceef62e072cf9a433ae6c74a1c5a10d94d3) but then didn't pursue it any

Re: [HACKERS] Regression tests failing if not launched on db regression

2013-12-05 Thread Michael Paquier
On Fri, Dec 6, 2013 at 12:02 PM, Peter Eisentraut pete...@gmx.net wrote: On Thu, 2013-12-05 at 17:12 +0900, Michael Paquier wrote: IMHO, the regression test suite would gain in consistency and portability if we do not refer to data that is database-dependent. I once did some similar fixes