Re: [HACKERS] Review: tests for client programs

2014-02-22 Thread Peter Eisentraut
On 2/9/14, 1:01 AM, Pavel Stehule wrote: b) Prepared tests fails when PostgreSQL server was up - should be checked and should to raise a valuable error message The original patch used a hard-coded port number, which was a mistake. I have changed this now to use a

Re: [HACKERS] Review: tests for client programs

2014-02-22 Thread Peter Eisentraut
On 2/17/14, 9:19 AM, Alvaro Herrera wrote: there can be option --with-client-tests and this option should to require IRC::Run A configure option seems a workable idea. In the future we might want to use the Perl test framework for other things, so perhaps --enable-perl-testing or

Re: [HACKERS] Review: tests for client programs

2014-02-17 Thread Alvaro Herrera
Pavel Stehule escribió: 2014-02-09 4:16 GMT+01:00 Peter Eisentraut pete...@gmx.net: a) Configure doesn't check a required IRC::Run module Clearly, we will need to figure out something about how to require this module, and possibly others in the future, as we expand the tests. Having

Re: [HACKERS] Review: tests for client programs

2014-02-11 Thread Robert Haas
On Sat, Feb 8, 2014 at 10:16 PM, Peter Eisentraut pete...@gmx.net wrote: Clearly, we will need to figure out something about how to require this module, and possibly others in the future, as we expand the tests. Having configure check for it is not necessarily the best solution -- What is

Re: [HACKERS] Review: tests for client programs

2014-02-08 Thread Peter Eisentraut
I posted an updated patch in the original thread. Please see the commit fest web site for the URL. On Thu, 2014-01-30 at 19:50 +0100, Pavel Stehule wrote: 6. I found only few issues: a) Configure doesn't check a required IRC::Run module Clearly, we will need to figure out something

Re: [HACKERS] Review: tests for client programs

2014-02-08 Thread Pavel Stehule
2014-02-09 4:16 GMT+01:00 Peter Eisentraut pete...@gmx.net: I posted an updated patch in the original thread. Please see the commit fest web site for the URL. On Thu, 2014-01-30 at 19:50 +0100, Pavel Stehule wrote: 6. I found only few issues: a) Configure doesn't check a required

[HACKERS] Review: tests for client programs

2014-01-30 Thread Pavel Stehule
Hello This patch creates a infrastructure for client side testing environment 1. Surely we want this patch, this infrastructure - lot of important functionality is not covered by tests - pg_dump, pg_basebackup, ... Without infrastructure is terrible work to create some tests. 2. This patch does

Re: [HACKERS] Review: tests for client programs

2014-01-30 Thread Craig Ringer
On 01/31/2014 02:50 AM, Pavel Stehule wrote: 5. I didn't test it on windows I guess that's my cue. I'll be home later today, and will take a look at it on my Windows test setup. -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training