Re: [HACKERS] Review for pg_dump: Sort overloaded functions in deterministic order

2012-10-18 Thread Alvaro Herrera
Joel Jacobson wrote: > Hi Joachim, > > Attached, please find new patch. Test unchanged. This was committed, as discussed in the original patch's thread. It would be great if reviewers could reply to the email that submits the patch, instead of creating a thread of their own. It helps keep thing

Re: [HACKERS] Review for pg_dump: Sort overloaded functions in deterministic order

2012-10-10 Thread Joel Jacobson
Hi Joachim, Attached, please find new patch. Test unchanged. Best regards, Joel > Patch looks good, all concerns that had been raised previously have > been addressed in this version of the patch. > > The only thing that IMO needs to change is a stylistic issue: > > if (fout->remoteVersion >= 8

[HACKERS] Review for pg_dump: Sort overloaded functions in deterministic order

2012-09-25 Thread Joachim Wieland
Patch looks good, all concerns that had been raised previously have been addressed in this version of the patch. The only thing that IMO needs to change is a stylistic issue: if (fout->remoteVersion >= 80200) { [...] (fout->remoteVersion >= 80400) ? "pg_catalog.pg_get_function_identity_ar