[HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Dag-Erling Smørgrav
As previously mentioned, I'm working on implementing [subject]. I think I've mostly worked it out, but I'm having trouble with the GENERATED ALWAYS case. My changes (see attached patch) can be summarized as follows: - in backend/utils/adt/misc.c: - added a force_default_value() function

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Rod Taylor
On the other hand, I seem to have botched the definition of force_default_value() in include/catalog/pg_proc.h, because adding the trigger manually doesn't seem to work either: | des=# \df force_default_value | List of functions | Result data type | Schema

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Dag-Erling Smørgrav
Rod Taylor [EMAIL PROTECTED] writes: I think a longer term solution would be to add a type to pg_attrdef and a bool for ALWAYS. (Tom?) I thought about it, but won't that change the on-disk format? Since minor version upgrades aren't supposed to require a dump / restore, and I understand 7.4 is

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Rod Taylor
On Sun, 2003-08-03 at 10:31, Dag-Erling Smørgrav wrote: Rod Taylor [EMAIL PROTECTED] writes: I think a longer term solution would be to add a type to pg_attrdef and a bool for ALWAYS. (Tom?) I thought about it, but won't that change the on-disk format? Since minor version upgrades aren't

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Tom Lane
[EMAIL PROTECTED] (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) writes: I thought about it, but won't that change the on-disk format? Since minor version upgrades aren't supposed to require a dump / restore, and I understand 7.4 is already in feature freeze, the earliest opportunity for something

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Tom Lane
Rod Taylor [EMAIL PROTECTED] writes: Yes it would. The solution you have already requires an initdb (changed pg_proc.h), as such will probably need to wait until 7.5 for integration. You might be able to squeeze it in as a contrib module for 7.4 though. Given that it also requires grammar and

Re: [HACKERS] SQL2003 GENERATED ... AS ... syntax

2003-08-03 Thread Rod Taylor
On Sun, 2003-08-03 at 14:35, Tom Lane wrote: Rod Taylor [EMAIL PROTECTED] writes: Yes it would. The solution you have already requires an initdb (changed pg_proc.h), as such will probably need to wait until 7.5 for integration. You might be able to squeeze it in as a contrib module for