Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-22 Thread Simon Riggs
On Mon, 2008-07-21 at 23:53 -0400, Owen Hartnett wrote: It would generate a schema dump where all the references to schema_name were replaced by masquerade_name. Good idea, can I tweak that a bit? No need to specify the name at pg_dump time. For text files, just use an option to specify

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-22 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: No need to specify the name at pg_dump time. For text files, just use an option to specify whether we change the actual schema name and replace it with the text :PGDUMPSCHEMA. pg_restore is in even worse position than pg_dump to make this happen; it would

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-22 Thread Joshua D. Drake
On Tue, 2008-07-22 at 16:58 +0100, Simon Riggs wrote: On Mon, 2008-07-21 at 23:53 -0400, Owen Hartnett wrote: No need to specify the name at pg_dump time. For text files, just use an option to specify whether we change the actual schema name and replace it with the text :PGDUMPSCHEMA.

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-22 Thread Simon Riggs
On Tue, 2008-07-22 at 13:35 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: No need to specify the name at pg_dump time. For text files, just use an option to specify whether we change the actual schema name and replace it with the text :PGDUMPSCHEMA. pg_restore is in even

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-21 Thread Owen Hartnett
At 8:34 AM +0100 7/11/08, Simon Riggs wrote: On Mon, 2008-07-07 at 15:46 +0200, Bernd Helmle wrote: There's a behavior in pg_dump that annoyed me a little bit, the last few times i had to deal with it: Consider you have to dump a specific namespace only, you are going to use pg_dump -n

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-11 Thread Simon Riggs
On Mon, 2008-07-07 at 15:46 +0200, Bernd Helmle wrote: There's a behavior in pg_dump that annoyed me a little bit, the last few times i had to deal with it: Consider you have to dump a specific namespace only, you are going to use pg_dump -n your_schema [-t tables]. I found it a

[HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Bernd Helmle
There's a behavior in pg_dump that annoyed me a little bit, the last few times i had to deal with it: Consider you have to dump a specific namespace only, you are going to use pg_dump -n your_schema [-t tables]. I found it a common use case to restore this dump into a different schema by

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Tom Lane
Bernd Helmle [EMAIL PROTECTED] writes: I found it a common use case to restore this dump into a different schema by simply changing the search_path. With included ownerships this doesn't work, since pg_dump always outputs the necessary DDL as follows: ALTER TABLE bernd.foo OWNER TO bernd;

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Bernd Helmle
--On Montag, Juli 07, 2008 10:33:35 -0400 Tom Lane [EMAIL PROTECTED] wrote: It seems like quite a useless change, since in general there will be other qualified references in the dump that can't safely be removed. IOW what you intend to do doesn't work anyway. Hmm, If i want to restore just

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Tom Lane
Bernd Helmle [EMAIL PROTECTED] writes: --On Montag, Juli 07, 2008 10:33:35 -0400 Tom Lane [EMAIL PROTECTED] wrote: It seems like quite a useless change, since in general there will be other qualified references in the dump that can't safely be removed. IOW what you intend to do doesn't work

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Andrew Dunstan
Bernd Helmle wrote: --On Montag, Juli 07, 2008 10:33:35 -0400 Tom Lane [EMAIL PROTECTED] wrote: It seems like quite a useless change, since in general there will be other qualified references in the dump that can't safely be removed. IOW what you intend to do doesn't work anyway. Hmm, If

Re: [HACKERS] Schema-qualified statements in pg_dump output

2008-07-07 Thread Bernd Helmle
--On Montag, Juli 07, 2008 11:09:56 -0400 Andrew Dunstan [EMAIL PROTECTED] wrote: I don't think in general we need to provide pg_dump with every possible permutation of uses that can achieved with the construction of simple tool chains. I always feel the same. However, i thought it would be