Re: [HACKERS] Shapes on the regression test for polygon

2015-03-19 Thread Bruce Momjian
On Tue, Oct 14, 2014 at 11:00:47AM -0400, Bruce Momjian wrote: > On Tue, Oct 14, 2014 at 05:40:06PM +0300, Emre Hasegeli wrote: > > > I extracted Emre's diagram adjustments from the patch and applied it, > > > and no tabs now. Emre, I assume your regression changes did not affect > > > the diagram

Re: [HACKERS] Shapes on the regression test for polygon

2014-10-14 Thread Bruce Momjian
On Tue, Oct 14, 2014 at 05:40:06PM +0300, Emre Hasegeli wrote: > > I extracted Emre's diagram adjustments from the patch and applied it, > > and no tabs now. Emre, I assume your regression changes did not affect > > the diagram contents. > > Thank you for looking at it. I wanted to make the test

Re: [HACKERS] Shapes on the regression test for polygon

2014-10-14 Thread Emre Hasegeli
> I extracted Emre's diagram adjustments from the patch and applied it, > and no tabs now. Emre, I assume your regression changes did not affect > the diagram contents. Thank you for looking at it. I wanted to make the tests consistent with the diagrams. Now they look better but they still don'

Re: [HACKERS] Shapes on the regression test for polygon

2014-10-11 Thread Bruce Momjian
On Wed, Jul 23, 2014 at 06:12:59PM -0400, Robert Haas wrote: > On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane wrote: > > Robert Haas writes: > >> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote: > >>> The first two shapes on src/test/regress/sql/polygon.sql do not make > >>> sense to me. > > >

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-25 Thread Tom Lane
Emre Hasegeli writes: >> Well, I think the number of tabs that makes them look best depends on >> your tab-stop setting. At present, I find that with 8-space tabs >> things seem to line up pretty well, whereas with your patch, 4-space >> tabs line up well. > 4 space tab-stop is not the project s

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-25 Thread Emre Hasegeli
> Well, I think the number of tabs that makes them look best depends on > your tab-stop setting. At present, I find that with 8-space tabs > things seem to line up pretty well, whereas with your patch, 4-space > tabs line up well. Either way, I have no idea what the picture is > supposed to mean,

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-23 Thread Robert Haas
On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote: >>> The first two shapes on src/test/regress/sql/polygon.sql do not make >>> sense to me. > >> Well, I think the number of tabs that makes them look best depends on >>

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-23 Thread Tom Lane
Robert Haas writes: > On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote: >> The first two shapes on src/test/regress/sql/polygon.sql do not make >> sense to me. > Well, I think the number of tabs that makes them look best depends on > your tab-stop setting. At present, I find that with 8-sp

Re: [HACKERS] Shapes on the regression test for polygon

2014-07-23 Thread Robert Haas
On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote: > The first two shapes on src/test/regress/sql/polygon.sql do not make > sense to me. They look more like polygons with some more tabs, > but still did not match the coordinates. I changed them to make > consistent with the shapes. I believ

[HACKERS] Shapes on the regression test for polygon

2014-07-21 Thread Emre Hasegeli
The first two shapes on src/test/regress/sql/polygon.sql do not make sense to me. They look more like polygons with some more tabs, but still did not match the coordinates. I changed them to make consistent with the shapes. I believe this was the intention of the original author. Patch attached