Re: [HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Andres Freund
On 2014-02-23 14:48:12 -0500, Tom Lane wrote: > Andres Freund writes: > > Currently the error handling of normal backends only does a > > LWLockReleaseAll() once CurrentTransactionState->state != TRANS_DEFAULT > > because it's called in AbortTransaction(). There's pretty damn few > > places that f

Re: [HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Tom Lane
Andres Freund writes: > Currently the error handling of normal backends only does a > LWLockReleaseAll() once CurrentTransactionState->state != TRANS_DEFAULT > because it's called in AbortTransaction(). There's pretty damn few > places that fiddle with lwlocks outside of a transaction command, but

[HACKERS] Should PostgresMain() do a LWLockReleaseAll()?

2014-02-23 Thread Andres Freund
Hi, Currently the error handling of normal backends only does a LWLockReleaseAll() once CurrentTransactionState->state != TRANS_DEFAULT because it's called in AbortTransaction(). There's pretty damn few places that fiddle with lwlocks outside of a transaction command, but I still do wonder whether