Re: [HACKERS] Should a plan node's result tuple slot be read-only to caller?

2005-11-14 Thread Martijn van Oosterhout
On Mon, Nov 14, 2005 at 10:14:53AM -0500, Tom Lane wrote: > The minimum-change way to fix the bug would be to revert the logic > change in nodeUnique.c and go back to maintaining a separate tuple copy. > But I'm thinking that this sort of thing could happen again. ISTM > it's not intuitive to allo

[HACKERS] Should a plan node's result tuple slot be read-only to caller?

2005-11-14 Thread Tom Lane
I looked into Frank van Vugt's recent report of bizarre behavior in 8.1: http://archives.postgresql.org/pgsql-bugs/2005-11/msg00121.php The problem occurs because execMain.c's ExecInsert() replaces the contents of the TupleTableSlot passed to it with whatever the trigger hands back. This slot is