Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-11-21 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Tom Lane wrote: >>> Last I checked, Magnus had promised to come up with suitable >>> documentation changes for this patch, but then he went off sailing... > >> Meh, I seem to have forgotten this one again. Here's a suggestion, seems

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-11-21 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Last I checked, Magnus had promised to come up with suitable >> documentation changes for this patch, but then he went off sailing... > Meh, I seem to have forgotten this one again. Here's a suggestion, seems > ok, or were you thinki

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-11-21 Thread Magnus Hagander
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: >> bruce wrote: >>> Tom Lane wrote: Currently, config.sgml still describes the new "enum" GUC variables as being of type "string" --- but pg_settings says they are "enum". This is not very consistent, but I wonder whether ch

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-08-25 Thread Magnus Hagander
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: >> bruce wrote: >>> Tom Lane wrote: Currently, config.sgml still describes the new "enum" GUC variables as being of type "string" --- but pg_settings says they are "enum". This is not very consistent, but I wonder whether ch

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-08-23 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > bruce wrote: >> Tom Lane wrote: >>> Currently, config.sgml still describes the new "enum" GUC variables >>> as being of type "string" --- but pg_settings says they are "enum". >>> This is not very consistent, but I wonder whether changing the docs >>> wou

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-08-21 Thread Bruce Momjian
bruce wrote: > Tom Lane wrote: > > Currently, config.sgml still describes the new "enum" GUC variables > > as being of type "string" --- but pg_settings says they are "enum". > > This is not very consistent, but I wonder whether changing the docs > > would be more confusing or less so. I note that

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-08-21 Thread Bruce Momjian
Tom Lane wrote: > Currently, config.sgml still describes the new "enum" GUC variables > as being of type "string" --- but pg_settings says they are "enum". > This is not very consistent, but I wonder whether changing the docs > would be more confusing or less so. I note that section 18.1 doesn't >

Re: [HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-07-01 Thread Magnus Hagander
Tom Lane wrote: > Currently, config.sgml still describes the new "enum" GUC variables > as being of type "string" --- but pg_settings says they are "enum". > This is not very consistent, but I wonder whether changing the docs > would be more confusing or less so. I note that section 18.1 doesn't >

[HACKERS] Should enum GUCs be listed as such in config.sgml?

2008-07-01 Thread Tom Lane
Currently, config.sgml still describes the new "enum" GUC variables as being of type "string" --- but pg_settings says they are "enum". This is not very consistent, but I wonder whether changing the docs would be more confusing or less so. I note that section 18.1 doesn't mention the enum alternat