Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2017-02-14 Thread Andres Freund
On 2017-02-14 17:58:23 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2016-11-26 08:41:28 -0800, Andres Freund wrote: > >> On November 26, 2016 8:06:26 AM PST, Tom Lane wrote: > >>> Those don't call functions, they call operators. Yes, I know that an > >>> operator has a function underlyi

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2017-02-14 Thread Tom Lane
Andres Freund writes: > On 2016-11-26 08:41:28 -0800, Andres Freund wrote: >> On November 26, 2016 8:06:26 AM PST, Tom Lane wrote: >>> Those don't call functions, they call operators. Yes, I know that an >>> operator has a function underlying it, but the user-level expectation >>> for track_func

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2017-02-14 Thread Andres Freund
On 2016-11-26 08:41:28 -0800, Andres Freund wrote: > On November 26, 2016 8:06:26 AM PST, Tom Lane wrote: > >Robert Haas writes: > >> On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund > >wrote: > >>> while working on my faster expression evaluation stuff I noticed > >that a > >>> lot of expression

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2016-11-26 Thread Andres Freund
On November 26, 2016 8:06:26 AM PST, Tom Lane wrote: >Robert Haas writes: >> On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund >wrote: >>> while working on my faster expression evaluation stuff I noticed >that a >>> lot of expression types that call functions don't call the necessary >>> functio

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2016-11-26 Thread Tom Lane
Robert Haas writes: > On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund wrote: >> while working on my faster expression evaluation stuff I noticed that a >> lot of expression types that call functions don't call the necessary >> functions to make track_functions work. >> >> ExecEvalFunc/ExecEvalOp

Re: [HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2016-11-26 Thread Robert Haas
On Fri, Nov 25, 2016 at 11:12 PM, Andres Freund wrote: > while working on my faster expression evaluation stuff I noticed that a > lot of expression types that call functions don't call the necessary > functions to make track_functions work. > > ExecEvalFunc/ExecEvalOper (via ExecMakeFunctionResul

[HACKERS] Skipping PgStat_FunctionCallUsage for many expressions

2016-11-25 Thread Andres Freund
Hi, while working on my faster expression evaluation stuff I noticed that a lot of expression types that call functions don't call the necessary functions to make track_functions work. ExecEvalFunc/ExecEvalOper (via ExecMakeFunctionResultNoSets) call pgstat_init_function_usage/pgstat_end_function