Re: [HACKERS] Small bug in replication lag tracking

2017-06-23 Thread Thomas Munro
On Sat, Jun 24, 2017 at 6:07 AM, Simon Riggs wrote: > On 23 June 2017 at 08:18, Simon Riggs wrote: >> On 23 June 2017 at 06:45, Thomas Munro wrote: >> >>> I discovered a thinko in the new replication lag interpolation code >>> that can cause a strange number to be reported occasionally. >> >> Th

Re: [HACKERS] Small bug in replication lag tracking

2017-06-23 Thread Simon Riggs
On 23 June 2017 at 08:18, Simon Riggs wrote: > On 23 June 2017 at 06:45, Thomas Munro wrote: > >> I discovered a thinko in the new replication lag interpolation code >> that can cause a strange number to be reported occasionally. > > Thanks, will review. I've pushed this, but I think we should l

Re: [HACKERS] Small bug in replication lag tracking

2017-06-23 Thread Simon Riggs
On 23 June 2017 at 06:45, Thomas Munro wrote: > I discovered a thinko in the new replication lag interpolation code > that can cause a strange number to be reported occasionally. Thanks, will review. -- Simon Riggshttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

[HACKERS] Small bug in replication lag tracking

2017-06-22 Thread Thomas Munro
Hi, I discovered a thinko in the new replication lag interpolation code that can cause a strange number to be reported occasionally. The interpolation code is designed to report increasing lag when replay gets stuck somewhere between two LSNs for which we have timestamp samples. The bug is that