Re: [HACKERS] StartupCLOG

2008-09-04 Thread Simon Riggs
On Thu, 2008-09-04 at 12:18 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I was thinking about what happens when you are performing a PITR using > > log records that contain a crash/recovery/shutdown checkpoint sequence. > > > I take it there's no problem there? > > I don'

Re: [HACKERS] StartupCLOG

2008-09-04 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I was thinking about what happens when you are performing a PITR using > log records that contain a crash/recovery/shutdown checkpoint sequence. > I take it there's no problem there? I don't really see one. I believe the reason for the StartupCLOG action

Re: [HACKERS] StartupCLOG

2008-09-04 Thread Simon Riggs
On Thu, 2008-09-04 at 11:12 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I notice that StartupCLOG zeroes out entries later than the nextxid when > > we complete recovery in StartupXLOG, reason given is safety in case we > > crash. > > > ISTM that we should also do that wh

Re: [HACKERS] StartupCLOG

2008-09-04 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I notice that StartupCLOG zeroes out entries later than the nextxid when > we complete recovery in StartupXLOG, reason given is safety in case we > crash. > ISTM that we should also do that whenever we see a Shutdown Checkpoint > in WAL, since that can be

[HACKERS] StartupCLOG

2008-09-04 Thread Simon Riggs
I notice that StartupCLOG zeroes out entries later than the nextxid when we complete recovery in StartupXLOG, reason given is safety in case we crash. ISTM that we should also do that whenever we see a Shutdown Checkpoint in WAL, since that can be caused by a shutdown immediate, shutdown abort or