Re: [HACKERS] Stats target increase vs compute_tsvector_stats()

2008-12-15 Thread Tom Lane
=?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= writes: > Tom Lane wrote: >> I came across this bit in ts_typanalyze.c: >> >> /* We want statistic_target * 100 lexemes in the MCELEM array */ >> num_mcelem = stats->attr->attstattarget * 100; >> >> I wonder whether the multiplier here should be changed

Re: [HACKERS] Stats target increase vs compute_tsvector_stats()

2008-12-14 Thread Jan UrbaƄski
Tom Lane wrote: I started making the changes to increase the default and maximum stats targets 10X, as I believe was agreed to in this thread: http://archives.postgresql.org/pgsql-hackers/2008-12/msg00386.php I came across this bit in ts_typanalyze.c: /* We want statistic_target * 100 l

Re: [HACKERS] Stats target increase vs compute_tsvector_stats()

2008-12-13 Thread Greg Stark
I don't quote know how this data but any constant factor seems like it would be arbitrary. It sounds like a more principled algorithm would be to use stats_target^2. But that has the same problem. Even stats_target^1.5 would be too big for stats_target 10,000. I think just using 10 is proba

[HACKERS] Stats target increase vs compute_tsvector_stats()

2008-12-13 Thread Tom Lane
I started making the changes to increase the default and maximum stats targets 10X, as I believe was agreed to in this thread: http://archives.postgresql.org/pgsql-hackers/2008-12/msg00386.php I came across this bit in ts_typanalyze.c: /* We want statistic_target * 100 lexemes in the MCEL