Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-29 Thread Michael Paquier
On Thu, Jul 30, 2015 at 1:37 AM, Heikki Linnakangas wrote: > On 07/29/2015 10:13 AM, Michael Paquier wrote: >> >> On Sat, Jul 25, 2015 at 10:54 PM, Michael Paquier >> wrote: >>> >>> An updated patch is attached. >> >> >> Attached is v9, that fixes conflicts with 01f6bb4 and recent commits >> that

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-29 Thread Heikki Linnakangas
On 07/29/2015 10:13 AM, Michael Paquier wrote: On Sat, Jul 25, 2015 at 10:54 PM, Michael Paquier wrote: An updated patch is attached. Attached is v9, that fixes conflicts with 01f6bb4 and recent commits that added TAP tests in pg_basebackup series. Thanks, committed with some more tweaking.

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-29 Thread Michael Paquier
On Sat, Jul 25, 2015 at 10:54 PM, Michael Paquier wrote: > An updated patch is attached. Attached is v9, that fixes conflicts with 01f6bb4 and recent commits that added TAP tests in pg_basebackup series. -- Michael 0001-TAP-tests-for-MSVC.patch Description: binary/octet-stream -- Sent via pg

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-25 Thread Michael Paquier
On Sat, Jul 25, 2015 at 4:14 PM, Noah Misch wrote: > On Fri, Jul 24, 2015 at 08:27:42PM +0300, Heikki Linnakangas wrote: >> On 06/25/2015 07:40 AM, Michael Paquier wrote: >> >Attached is v7, rebased on 0b157a0. >> >> Thanks! I fiddled with this a bit more, to centralize more of the >> platform-dep

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-25 Thread Michael Paquier
On Sat, Jul 25, 2015 at 2:27 AM, Heikki Linnakangas wrote: > On 06/25/2015 07:40 AM, Michael Paquier wrote: >> >> On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: >>> >>> Here is v6, a rebased version on HEAD (79f2b5d). There were some >>> conflicts with the indentation and some other patch

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-25 Thread Noah Misch
On Fri, Jul 24, 2015 at 08:27:42PM +0300, Heikki Linnakangas wrote: > On 06/25/2015 07:40 AM, Michael Paquier wrote: > >Attached is v7, rebased on 0b157a0. > > Thanks! I fiddled with this a bit more, to centralize more of the > platform-dependent stuff to RewindTest.pm. Also, Windows doesn't have

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-24 Thread Michael Paquier
On Sat, Jul 25, 2015 at 3:27 AM, Andrew Dunstan wrote: > > On 07/24/2015 01:27 PM, Heikki Linnakangas wrote: >> >> On 06/25/2015 07:40 AM, Michael Paquier wrote: >>> >>> On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: Here is v6, a rebased version on HEAD (79f2b5d). There were so

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-24 Thread Andrew Dunstan
On 07/24/2015 01:27 PM, Heikki Linnakangas wrote: On 06/25/2015 07:40 AM, Michael Paquier wrote: On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: Here is v6, a rebased version on HEAD (79f2b5d). There were some conflicts with the indentation and some other patches related to pg_rewind a

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-24 Thread Heikki Linnakangas
On 06/25/2015 07:40 AM, Michael Paquier wrote: On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: Here is v6, a rebased version on HEAD (79f2b5d). There were some conflicts with the indentation and some other patches related to pg_rewind and initdb's tests. Attached is v7, rebased on 0b15

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-07-09 Thread Michael Paquier
On Thu, Jun 25, 2015 at 1:40 PM, Michael Paquier wrote: > On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: >> Here is v6, a rebased version on HEAD (79f2b5d). There were some >> conflicts with the indentation and some other patches related to >> pg_rewind and initdb's tests. > > Attached is

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-06-24 Thread Michael Paquier
On Tue, May 26, 2015 at 3:39 PM, Michael Paquier wrote: > Here is v6, a rebased version on HEAD (79f2b5d). There were some > conflicts with the indentation and some other patches related to > pg_rewind and initdb's tests. Attached is v7, rebased on 0b157a0. -- Michael From 4b960b29446c01ca2f1a44f

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-05-25 Thread Michael Paquier
On Fri, Apr 24, 2015 at 11:26 AM, Michael Paquier wrote: > On Mon, Apr 20, 2015 at 9:01 PM, Michael Paquier > wrote: >> On Sun, Apr 19, 2015 at 10:01 PM, Michael Paquier >> wrote: >>> Note as well that this patch uses the following patches fixing >>> independent issues: >>> ... >> >> Attached is

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-23 Thread Michael Paquier
On Mon, Apr 20, 2015 at 9:01 PM, Michael Paquier wrote: > On Sun, Apr 19, 2015 at 10:01 PM, Michael Paquier > wrote: >> Note as well that this patch uses the following patches fixing >> independent issues: >> ... > > Attached is v4. I added a switch in config.pl to be consistent with > ./configur

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-20 Thread Michael Paquier
On Sun, Apr 19, 2015 at 10:01 PM, Michael Paquier wrote: > Note as well that this patch uses the following patches fixing > independent issues: > ... Attached is v4. I added a switch in config.pl to be consistent with ./configure and --enable-tap-tests. -- Michael From f532bbd2522b3a1784038d9863

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-19 Thread Michael Paquier
On Fri, Apr 10, 2015 at 11:29 AM, Michael Paquier wrote: > Here is a v2 with the following changes: > - Use an environment variable to define where pg_regress is located. > - Use SSPI to access a node in the tests, to secure the test environment. > - Rebase on latest HEAD > - SSL tests are run only

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-02 Thread Michael Paquier
Thanks for your input, Noah. On Fri, Apr 3, 2015 at 3:22 PM, Noah Misch wrote: > Each Windows patch should cover all Windows build systems; patches that fix a > problem in the src/tools/msvc build while leaving it broken in the GNU make > build are a bad trend. In this case, I expect you'll need

Re: [HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-02 Thread Noah Misch
Each Windows patch should cover all Windows build systems; patches that fix a problem in the src/tools/msvc build while leaving it broken in the GNU make build are a bad trend. In this case, I expect you'll need few additional changes to cover both. On Thu, Apr 02, 2015 at 06:30:02PM +0900, Micha

[HACKERS] Supporting TAP tests with MSVC and Windows

2015-04-02 Thread Michael Paquier
Hi all, (Adding Peter and Heikki in CC for awareness) Please find attached a WIP patch to support TAP tests with MSVC. The tests can be kicked with this command: vcregress tapcheck There are a couple of things to note with this patch, and I would like to have some input for some of those things: