Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Takahiro Itagaki
Robert Haas wrote: > With respect to tab completion, ALTER TABLESPACE x currently completes > with only "OWNER TO" or "RENAME TO"; we need to add "SET" to that > list. My bad. Ok, I'll go for it. I see non-tab-completion parts are too late for 9.0. Regards, --- Takahiro Itagaki NTT Open Sourc

Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Tom Lane
Robert Haas writes: > I don't think we can change this because "ALTER COLUMN SET STATISTICS" > is not new in 8.5. We added (and then removed) "ALTER COLUMN SET > STATISTICS DISTINCT", but that's not the same thing. > What we COULD do is add a column option called statistics_target and > then mak

Re: [HACKERS] Syntax supplements for SET options

2010-01-25 Thread Robert Haas
On Sun, Jan 24, 2010 at 9:16 PM, Takahiro Itagaki wrote: > I found a couple of incomplete syntax when I was adjusting psql > automatic tab completion for HEAD. So, I'm slightly confused about whether you want to fix tab completion or behavior, but... > 1. We cannot specify tablespace options on

[HACKERS] Syntax supplements for SET options

2010-01-24 Thread Takahiro Itagaki
I found a couple of incomplete syntax when I was adjusting psql automatic tab completion for HEAD. 1. We cannot specify tablespace options on "CREATE TABLESPACE" though "ALTER TABLESPACE" supports generic options by SET (...). 2. Should we still support "ALTER COLUMN SET STATISTICS" though