Applied.
> Here is one with a stray character removed.
>
>
> Index: src/backend/utils/misc/guc-file.l
> ===
> RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/misc/guc-file.l,v
> retrieving revision 1.4
> diff -c -r
Sorry, this was not applied. Seems it is already fixed.
> * Peter Eisentraut <[EMAIL PROTECTED]> [001113 23:52]:
> > Okay, but you can't make these options PGC_SIGHUP unless you make sure to
> > close and re-open the syslog channel whenever these options
> > change. Probably ought to be PGC_P
Applied.
> * Peter Eisentraut <[EMAIL PROTECTED]> [001113 23:52]:
> > Okay, but you can't make these options PGC_SIGHUP unless you make sure to
> > close and re-open the syslog channel whenever these options
> > change. Probably ought to be PGC_POSTMASTER.
> Here is a patch to change to PGC_POS
Here is one with a stray character removed.
Index: src/backend/utils/misc/guc-file.l
===
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/utils/misc/guc-file.l,v
retrieving revision 1.4
diff -c -r1.4 guc-file.l
*** src/back
* Peter Eisentraut <[EMAIL PROTECTED]> [001115 13:11]:
> Larry Rosenman writes:
>
> > > syntax is lexically compatible with the syntax of the SET command.
> > > Therefore you can't have "funny" characters in 'value' unless
> > > single-quoted.
> > I added period(.), hyphen(-), and underscore(_)
* Peter Eisentraut <[EMAIL PROTECTED]> [001115 10:26]:
> Larry Rosenman writes:
>
> > Ok, so what I think(?) needs to happen is the FIXME: tag needs to be
> > handled. We need to code a version of src/backend/parser/scansup.c
> > that doesn't use palloc, and also strips the apostrophes from the
* Larry Rosenman <[EMAIL PROTECTED]> [001114 20:45]:
> * Larry Rosenman <[EMAIL PROTECTED]> [001114 16:56]:
> > Ok, so what I think(?) needs to happen is the FIXME: tag needs to be
> > handled. We need to code a version of src/backend/parser/scansup.c
> > that doesn't use palloc, and also strips
* Larry Rosenman <[EMAIL PROTECTED]> [001114 16:56]:
> Ok, so what I think(?) needs to happen is the FIXME: tag needs to be
> handled. We need to code a version of src/backend/parser/scansup.c
> that doesn't use palloc, and also strips the apostrophes from the
> front and end of the string? This
* Larry Rosenman <[EMAIL PROTECTED]> [001114 16:06]:
> * Peter Eisentraut <[EMAIL PROTECTED]> [001114 16:03]:
> > Larry Rosenman writes:
> >
> > > log_connections = on
> > > fsync = off
> > > #max_backends = 64
> > > syslog_facility = LOCAL5.3we4rwjtasrtuert
> >
> > It's the dot. The regular ex
* Peter Eisentraut <[EMAIL PROTECTED]> [001114 16:03]:
> Larry Rosenman writes:
>
> > log_connections = on
> > fsync = off
> > #max_backends = 64
> > syslog_facility = LOCAL5.3we4rwjtasrtuert
>
> It's the dot. The regular expression needs some work. Make a note to
> always test with identical
Larry Rosenman writes:
> log_connections = on
> fsync = off
> #max_backends = 64
> syslog_facility = LOCAL5.3we4rwjtasrtuert
It's the dot. The regular expression needs some work. Make a note to
always test with identical values next time. :-)
> syslog_progid = pgtest
> syslog=2
> showportnumb
* Larry Rosenman <[EMAIL PROTECTED]> [001114 14:44]:
> * Peter Eisentraut <[EMAIL PROTECTED]> [001114 14:39]:
> > Larry Rosenman writes:
> >
> > > * Peter Eisentraut <[EMAIL PROTECTED]> [001114 13:18]:
> > > > Larry Rosenman writes:
> > > >
> > > > > > I can't reproduce that. I set 'syslog_fac
* Peter Eisentraut <[EMAIL PROTECTED]> [001114 14:39]:
> Larry Rosenman writes:
>
> > * Peter Eisentraut <[EMAIL PROTECTED]> [001114 13:18]:
> > > Larry Rosenman writes:
> > >
> > > > > I can't reproduce that. I set 'syslog_facility = local97' and got the
> > > > > right error message.
> > > >
Larry Rosenman writes:
> * Peter Eisentraut <[EMAIL PROTECTED]> [001114 13:18]:
> > Larry Rosenman writes:
> >
> > > > I can't reproduce that. I set 'syslog_facility = local97' and got the
> > > > right error message.
> > > try setting it in postgresql.conf
> >
> > That's what I did.
> Hmm
Larry Rosenman writes:
> Here is a patch to change to PGC_POSTMASTER...
Thanks. I polished things a bit and it works well for me now.
--
Peter Eisentraut [EMAIL PROTECTED] http://yi.org/peter-e/
* Peter Eisentraut <[EMAIL PROTECTED]> [001114 13:18]:
> Larry Rosenman writes:
>
> > > I can't reproduce that. I set 'syslog_facility = local97' and got the
> > > right error message.
> > try setting it in postgresql.conf
>
> That's what I did.
Hmm. Here is what I get:
$ ../bin/pg_ctl -D
Tom Lane writes:
> > I can't reproduce that. I set 'syslog_facility = local97' and got the
> > right error message.
>
> I'm surprised you get any error message at all (as seen by a client,
> that is, not as seen in the postmaster log).
I was talking about the postmaster log. No clients involv
Larry Rosenman writes:
> > I can't reproduce that. I set 'syslog_facility = local97' and got the
> > right error message.
> try setting it in postgresql.conf
That's what I did.
--
Peter Eisentraut [EMAIL PROTECTED] http://yi.org/peter-e/
I said:
> I'm surprised you get any error message at all (as seen by a client,
> that is, not as seen in the postmaster log). AFAICT, backend libpq
> is not fired up until well down inside PostmasterMain --- look at the
> call to pq_init.
s/PostmasterMain/PostgresMain/ ...
* Peter Eisentraut <[EMAIL PROTECTED]> [001114 12:45]:
> Larry Rosenman writes:
>
> > In looking at this some more, it appears that *SOMETHING* is not
> > allowing messages from set_config_option() in
> > /src/backend/utils/misc/guc.c out WHEN WE ARE DEALING WITH syslog type
> > stuff and we are
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Larry Rosenman writes:
>> In looking at this some more, it appears that *SOMETHING* is not
>> allowing messages from set_config_option() in
>> /src/backend/utils/misc/guc.c out WHEN WE ARE DEALING WITH syslog type
>> stuff and we are reading it from t
* Peter Eisentraut <[EMAIL PROTECTED]> [001113 23:52]:
> Okay, but you can't make these options PGC_SIGHUP unless you make sure to
> close and re-open the syslog channel whenever these options
> change. Probably ought to be PGC_POSTMASTER.
Here is a patch to change to PGC_POSTMASTER...
Index: g
* Peter Eisentraut <[EMAIL PROTECTED]> [001113 23:52]:
> Okay, but you can't make these options PGC_SIGHUP unless you make sure to
> close and re-open the syslog channel whenever these options
> change. Probably ought to be PGC_POSTMASTER.
Is there a mechanism to "hear" the SIGHUP? Although, it p
Larry Rosenman writes:
> * Peter Eisentraut <[EMAIL PROTECTED]> [001113 17:43]:
> > Larry Rosenman writes:
> >
> > > Ok, You guys are probably tired of me, BUT, here is another one, that
> > > adds the facility to set the program name used in syslog.
> > > (this includes the other ones).
> >
> Larry Rosenman writes:
>
> > Ok, You guys are probably tired of me, BUT, here is another one, that
> > adds the facility to set the program name used in syslog.
> > (this includes the other ones).
>
> Why would one want to do that? ISTM that that would just be a means to
> play games with t
There were problems? I saw someone asking why it hadn't been applied
yet. What do people want? I can back it out.
> Bruce Momjian writes:
>
> > Applied.
>
> Uh, shouldn't the problems Larry pointed out be fixed first?
>
> >
> >
> > > Ok, You guys are probably tired of me, BUT, here is an
* Peter Eisentraut <[EMAIL PROTECTED]> [001113 17:43]:
> Larry Rosenman writes:
>
> > Ok, You guys are probably tired of me, BUT, here is another one, that
> > adds the facility to set the program name used in syslog.
> > (this includes the other ones).
>
> Why would one want to do that? ISTM
* Peter Eisentraut <[EMAIL PROTECTED]> [001113 17:41]:
> Bruce Momjian writes:
>
> > Applied.
>
> Uh, shouldn't the problems Larry pointed out be fixed first?
I don't think the problems are BECAUSE of my code. The new stuff
works, just putting the new options in postgresql.conf with a bad
value
> * Peter Eisentraut <[EMAIL PROTECTED]> [001113 17:41]:
> > Bruce Momjian writes:
> >
> > > Applied.
> >
> > Uh, shouldn't the problems Larry pointed out be fixed first?
> I don't think the problems are BECAUSE of my code. The new stuff
> works, just putting the new options in postgresql.conf
* Bruce Momjian <[EMAIL PROTECTED]> [001113 15:36]:
> Applied.
>
Thanks. FWIW, I had to pull the CVS copy of guc.c (my cvs update got
two copies of my updates to the table).
Comments on my postgresql.conf issues from the rest of the -hackers
corp?
Thanks!
--
Larry Rosenman
Applied.
> Ok, You guys are probably tired of me, BUT, here is another one, that
> adds the facility to set the program name used in syslog.
> (this includes the other ones).
>
> One gotcha, the parser doesn't like special characters in strings.
> For example, i tried to use pg-test, and if f
* Larry Rosenman <[EMAIL PROTECTED]> [001112 19:20]:
> Ok, You guys are probably tired of me, BUT, here is another one, that
> adds the facility to set the program name used in syslog.
> (this includes the other ones).
>
> One gotcha, the parser doesn't like special characters in strings.
> For
Ok, You guys are probably tired of me, BUT, here is another one, that
adds the facility to set the program name used in syslog.
(this includes the other ones).
One gotcha, the parser doesn't like special characters in strings.
For example, i tried to use pg-test, and if failed the parse coming
Here is a cleaned up patch, without the elog() and fprintf(), and some
minor formatting fixups.
Index: doc/src/sgml/runtime.sgml
===
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/runtime.sgml,v
retrieving revision 1.33
* Larry Rosenman <[EMAIL PROTECTED]> [001112 15:41]:
> * Larry Rosenman <[EMAIL PROTECTED]> [001112 14:02]:
> > OK, I don't like it (it just says "syntax error"), but here is an
> > improved version. I also switched to strcasecmp...
> In looking at this some more, it appears that *SOMETHING* is n
* Larry Rosenman <[EMAIL PROTECTED]> [001112 14:02]:
> OK, I don't like it (it just says "syntax error"), but here is an
> improved version. I also switched to strcasecmp...
In looking at this some more, it appears that *SOMETHING* is not
allowing messages from set_config_option() in
/src/backend
OK, I don't like it (it just says "syntax error"), but here is an
improved version. I also switched to strcasecmp...
Index: doc/src/sgml/runtime.sgml
===
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/runtime.sgml,v
retr
Here is a patch for allowing the syslog facility to be set.
Index: doc/src/sgml/runtime.sgml
===
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/src/sgml/runtime.sgml,v
retrieving revision 1.33
diff -c -r1.33 runtime.sgml
*** doc/s
38 matches
Mail list logo
