Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-02 Thread ITAGAKI Takahiro
Bruce Momjian pgman@candle.pha.pa.us wrote: - Is fillfactor useful for hash and gist indexes? I think hash does not need it, but gist might need it. Not sure. We don't know what type of index a GIST will be so we have no way of knowing. I am thinking we can implement just btree now

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-02 Thread Bruce Momjian
ITAGAKI Takahiro wrote: Bruce Momjian pgman@candle.pha.pa.us wrote: - Is fillfactor useful for hash and gist indexes? I think hash does not need it, but gist might need it. Not sure. We don't know what type of index a GIST will be so we have no way of knowing. I am thinking

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Bruce Momjian
ITAGAKI Takahiro wrote: Hi Hackers, I'm trying the following TODO item: [Indexes] - Add fillfactor to control reserved free space during index creation I have already made an patch and it seemed to work well. Great. And now, I need advice on some issues. - Is it appropriate

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Tom Lane
Bruce Momjian pgman@candle.pha.pa.us writes: - Should indexes remember their fillfactors when they are created? The last fillfactors will be used on next reindex. They should remember, for sure, and REINDEX should use it. It think this is similar to the ALTER TABLE ALTER [ COLUMN ] ... SET

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian pgman@candle.pha.pa.us writes: - Should indexes remember their fillfactors when they are created? The last fillfactors will be used on next reindex. They should remember, for sure, and REINDEX should use it. It think this is similar to the ALTER TABLE

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Christopher Kings-Lynne
If you want it to be dumped by pg_dump (which is debatable IMHO) then it MUST NOT be a syntax extension, it has to be driven by a GUC variable, else we have compatibility problems with the dumps. We just went through this with WITH/WITHOUT OIDS. Compatibility problems? CREATE INDEX isn't an

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: Compatibility problems? CREATE INDEX isn't an SQL standard command is it? No, but it'll cause unnecessary cross-version compatibility issues for us. regards, tom lane ---(end of

Re: [HACKERS] TODO-Item: B-tree fillfactor control

2006-02-01 Thread Bruce Momjian
Tom Lane wrote: Christopher Kings-Lynne [EMAIL PROTECTED] writes: Compatibility problems? CREATE INDEX isn't an SQL standard command is it? No, but it'll cause unnecessary cross-version compatibility issues for us. It is true it isn't SQL standard, but I think our CREATE INDEX syntax

[HACKERS] TODO-Item: B-tree fillfactor control

2006-01-18 Thread ITAGAKI Takahiro
Hi Hackers, I'm trying the following TODO item: [Indexes] - Add fillfactor to control reserved free space during index creation I have already made an patch and it seemed to work well. $ ./pgbench -i -s 10 # select relpages from pg_class where relname = 'accounts_pkey'; relpages |