[HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Gevik Babakhani
Hi, As advised, I spend a moment reading the code regarding the GRANT and REVOKE In order to add a new privilege to the ACL, I have created a mini patch. Could this be checked to see if I am on the right track? http://www.xs4all.nl/~gevik/patch/alpha.patch Thank you.

Re: [HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Alvaro Herrera
Gevik Babakhani wrote: As advised, I spend a moment reading the code regarding the GRANT and REVOKE In order to add a new privilege to the ACL, I have created a mini patch. Could this be checked to see if I am on the right track? http://www.xs4all.nl/~gevik/patch/alpha.patch You are

Re: [HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Gevik Babakhani
Thank you :) You are missing an ACL_*_CHR symbol and updating the ACL_ALL_RIGHTS_STR symbol. That is why I could not see the new permission in pg_database. I was actually looking for that for sometime :) I have added the ACL_*_CHR 'D' Is this okay? Also, you should know that changing this

Re: [HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Alvaro Herrera
Gevik Babakhani wrote: Thank you :) You are missing an ACL_*_CHR symbol and updating the ACL_ALL_RIGHTS_STR symbol. That is why I could not see the new permission in pg_database. I was actually looking for that for sometime :) I have added the ACL_*_CHR 'D' Is this okay? Hum, you

Re: [HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Tom Lane
Gevik Babakhani [EMAIL PROTECTED] writes: I have added the ACL_*_CHR 'D' Is this okay? That seems an excessively random choice of character for CONNECT privilege. I see that 'C' is already taken, but we could use 'c'. Also, you should know that changing this requires a change in

Re: [HACKERS] TODO item question [pg_hba.conf]

2006-04-21 Thread Gevik Babakhani
Hi, I have created a new patch. Please check to see if I am on the right track. 1) The GRANT and REVOKE statements look like: GRANT CONNECTION ON DATABASE db1 TO user1 (,user2,user3) REVOKE CONNECTION ON DATABASE db1 TO user1 (,user2,user3) 2) The file parsenodes.h is updated to support