Re: [HACKERS] TransactionIdGetCommitTsData and its dereferenced pointers

2015-08-21 Thread Alvaro Herrera
Michael Paquier wrote: > TransactionIdGetCommitTsData@commit_ts.c does the following: > if (ts) > *ts = entry.time; > [...] > return *ts != 0; > This is a bad idea, because if TransactionIdGetCommitTsData is called > with ts == NULL this would simply crash. It seems to me that

[HACKERS] TransactionIdGetCommitTsData and its dereferenced pointers

2015-08-11 Thread Michael Paquier
Hi all, TransactionIdGetCommitTsData@commit_ts.c does the following: if (ts) *ts = entry.time; [...] return *ts != 0; This is a bad idea, because if TransactionIdGetCommitTsData is called with ts == NULL this would simply crash. It seems to me that it makes little sense to have