Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Kyotaro HORIGUCHI
Thank you. At Wed, 26 Oct 2016 10:20:28 -0400, Tom Lane wrote in <17387.1477491...@sss.pgh.pa.us> > Kyotaro HORIGUCHI writes: > > Hello, compiler complains about unused variable during build > > postgres_fdw without assertions (!--enable-cassert). > > The attched patch removes it and moves into

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Kyotaro HORIGUCHI
Hi, At Wed, 26 Oct 2016 11:00:17 +0530, Ashutosh Bapat wrote in > On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI > wrote: > Thanks for the patch and sorry for missing this in the review. I > > The patch applies but seems to have a trailing white space. Oops. My 'git commit' has a hook t

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-26 Thread Tom Lane
Kyotaro HORIGUCHI writes: > Hello, compiler complains about unused variable during build > postgres_fdw without assertions (!--enable-cassert). > The attched patch removes it and moves into the assertion below it. Pushed, thanks. regards, tom lane -- Sent via pgsql-hac

Re: [HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-25 Thread Ashutosh Bapat
On Wed, Oct 26, 2016 at 6:19 AM, Kyotaro HORIGUCHI wrote: > Hello, compiler complains about unused variable during build > postgres_fdw without assertions (!--enable-cassert). > > deparse.c: In function ‘deparseFromExpr’: > deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variabl

[HACKERS] Unused variable in postgres_fdw/deparse.c

2016-10-25 Thread Kyotaro HORIGUCHI
Hello, compiler complains about unused variable during build postgres_fdw without assertions (!--enable-cassert). deparse.c: In function ‘deparseFromExpr’: deparse.c:1029:14: warning: unused variable ‘foreignrel’ [-Wunused-variable] RelOptInfo *foreignrel = context->foreignrel; ^~~