Re: [HACKERS] Use sync commit for logical replication apply in TAP tests

2017-04-20 Thread Tom Lane
Peter Eisentraut writes: > Double hmm, I ran a few more tests and different machines and get > consistent but underwhelming improvements. > I don't mind applying the patch nonetheless, but maybe we can get a few > more test results from others. > (Instructions:

Re: [HACKERS] Use sync commit for logical replication apply in TAP tests

2017-04-20 Thread Peter Eisentraut
On 4/20/17 09:46, Petr Jelinek wrote: > On 20/04/17 14:57, Peter Eisentraut wrote: >> On 4/18/17 22:25, Petr Jelinek wrote: >>> The commit 887227a1c changed the defaults for subscriptions to do async >>> commit. But since the tests often wait for disk flush and there is no >>> concurrent activity

Re: [HACKERS] Use sync commit for logical replication apply in TAP tests

2017-04-20 Thread Petr Jelinek
On 20/04/17 14:57, Peter Eisentraut wrote: > On 4/18/17 22:25, Petr Jelinek wrote: >> The commit 887227a1c changed the defaults for subscriptions to do async >> commit. But since the tests often wait for disk flush and there is no >> concurrent activity this has increased the amount of time needed

Re: [HACKERS] Use sync commit for logical replication apply in TAP tests

2017-04-20 Thread Peter Eisentraut
On 4/18/17 22:25, Petr Jelinek wrote: > The commit 887227a1c changed the defaults for subscriptions to do async > commit. But since the tests often wait for disk flush and there is no > concurrent activity this has increased the amount of time needed for > each test. So the attached patch changes

[HACKERS] Use sync commit for logical replication apply in TAP tests

2017-04-18 Thread Petr Jelinek
Hi, The commit 887227a1c changed the defaults for subscriptions to do async commit. But since the tests often wait for disk flush and there is no concurrent activity this has increased the amount of time needed for each test. So the attached patch changes the subscriptions create in tab tests to