On 2013-09-06 21:55:09 +0100, Greg Stark wrote:
> On Sun, Jun 9, 2013 at 10:25 PM, Noah Misch wrote:
>
> > - Test recovery, such as by running a streaming replica under Memcheck
> > while
> > the primary runs "make installcheck-world".
> >
>
> In general we need a lot more testing on the recov
On Fri, Sep 06, 2013 at 09:55:09PM +0100, Greg Stark wrote:
> On Sun, Jun 9, 2013 at 10:25 PM, Noah Misch wrote:
> > - Memcheck has support for detecting leaks. I have not explored that
> > side at
> > all, always passing --leak-check=no. We could add support for freeing
> > "everything" at
On Wed, Aug 28, 2013 at 10:30:34PM -0400, Noah Misch wrote:
> On Wed, Aug 28, 2013 at 03:16:14PM +0200, Andres Freund wrote:
> > I vote for just removing that VALGRIND_PRINTF - it doesn't give you
> > anything you cannot easily achieve otherwise...
Done.
> I'd like to see a buildfarm member runni
On Sun, Jun 9, 2013 at 10:25 PM, Noah Misch wrote:
> - Test recovery, such as by running a streaming replica under Memcheck
> while
> the primary runs "make installcheck-world".
>
In general we need a lot more testing on the recovery code.
> - Memcheck has support for detecting leaks. I ha
On Wed, Aug 28, 2013 at 03:16:14PM +0200, Andres Freund wrote:
> On 2013-08-27 23:46:23 -0400, Noah Misch wrote:
> > On Tue, Aug 27, 2013 at 04:14:27PM +0200, Andres Freund wrote:
> > > On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
> > > > ***
> > > > *** 846,851 exec_simple_quer
On 2013-08-27 23:46:23 -0400, Noah Misch wrote:
> On Tue, Aug 27, 2013 at 04:14:27PM +0200, Andres Freund wrote:
> > On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
> > > ***
> > > *** 846,851 exec_simple_query(const char *query_string)
> > > --- 847,856
> > >
> > >
On Tue, Aug 27, 2013 at 04:14:27PM +0200, Andres Freund wrote:
> On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
> > ***
> > *** 846,851 exec_simple_query(const char *query_string)
> > --- 847,856
> >
> > TRACE_POSTGRESQL_QUERY_START(query_string);
> >
> > + #ifdef U
Sent from my iPad
On 27-Aug-2013, at 19:44, Andres Freund wrote:
> Hi Noah,
>
> On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
>> *** a/src/backend/tcop/postgres.c
>> --- b/src/backend/tcop/postgres.c
>> ***
>> *** 69,74
>> --- 69,75
>> #include "tcop/tcopprot.h"
>> #
Hi Noah,
On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
> *** a/src/backend/tcop/postgres.c
> --- b/src/backend/tcop/postgres.c
> ***
> *** 69,74
> --- 69,75
> #include "tcop/tcopprot.h"
> #include "tcop/utility.h"
> #include "utils/lsyscache.h"
> + #include "utils/mem
On 2013-06-09 17:25:59 -0400, Noah Misch wrote:
> Valgrind's Memcheck tool[1] is handy for finding bugs, but our use of a custom
> allocator limits its ability to detect problems in unmodified PostgreSQL.
> During the 9.1 beta cycle, I found some bugs[2] with a rough patch adding
> instrumentation
Valgrind's Memcheck tool[1] is handy for finding bugs, but our use of a custom
allocator limits its ability to detect problems in unmodified PostgreSQL.
During the 9.1 beta cycle, I found some bugs[2] with a rough patch adding
instrumentation to aset.c and mcxt.c such that Memcheck understood our
a
11 matches
Mail list logo
