Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-10 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: Attached patch allows to setup storage parameter for space reservation. What is the point of this? We don't need it for 8.3-8.4, we aren't going to back-patch such a thing into 8.2 or before (certainly not before, since reloptions

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-10 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Tom Lane napsal(a): What is the point of this? We don't need it for 8.3-8.4, we aren't going to back-patch such a thing into 8.2 or before (certainly not before, since reloptions didn't exist before 8.2), and I would hope we put in a more general

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-10 Thread Zdenek Kotala
Robert Haas napsal(a): Let's suppose, for example, that in 8.5 we decide to change some type that is presently 16 bits to 32 bits, or 8 bits to 16 bits, etc. This will make some tuples bigger, and potentially much bigger, but since it presumably won't be a commonly used data-type, most tuples

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-10 Thread Martijn van Oosterhout
On Sun, Nov 09, 2008 at 11:28:50PM -0500, Robert Haas wrote: Well, if that's what it is, I think it's a fairly poor design decision. When I upgrade Oracle, SQL Server, or MySQL, I don't need to plan the amount of free space in my blocks a year or more before an upgrade. In fact, I don't

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Decibel!
On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: On Sat, Nov 8, 2008 at 8:08 PM, Tom Lane [EMAIL PROTECTED] wrote: Zdenek Kotala [EMAIL PROTECTED] writes: Attached patch allows to setup storage parameter for space reservation. What is the point of this? That's my question. Why is this

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Robert Haas
Well, if that's what it is, I think it's a fairly poor design decision. When I upgrade Oracle, SQL Server, or MySQL, I don't need to plan the amount of free space in my blocks a year or more before an upgrade. In fact, I don't have to plan it at all... it's completely handled by the

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Zdenek Kotala
Jonah H. Harris napsal(a): On Sun, Nov 9, 2008 at 7:55 PM, Decibel! [EMAIL PROTECTED] wrote: On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: That's my question. Why is this needed at all? I suspect this is to deal with needing to reserve space in a cluster that you're planning on

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-09 Thread Jonah H. Harris
On Sun, Nov 9, 2008 at 7:55 PM, Decibel! [EMAIL PROTECTED] wrote: On Nov 8, 2008, at 8:35 PM, Jonah H. Harris wrote: That's my question. Why is this needed at all? I suspect this is to deal with needing to reserve space in a cluster that you're planning on upgrading to a new version that

[HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-08 Thread Zdenek Kotala
Attached patch allows to setup storage parameter for space reservation. I use reloptions capability for it. You can use it: CREATE TABLE test(id int) with (reservedspace=10); The idea is to reduce freespace value about reservedspace on places where PageGet(Heap)FreeSpace is called. I need

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-08 Thread Tom Lane
Zdenek Kotala [EMAIL PROTECTED] writes: Attached patch allows to setup storage parameter for space reservation. What is the point of this? We don't need it for 8.3-8.4, we aren't going to back-patch such a thing into 8.2 or before (certainly not before, since reloptions didn't exist before

Re: [HACKERS] WIP: Page space reservation (pgupgrade)

2008-11-08 Thread Jonah H. Harris
On Sat, Nov 8, 2008 at 8:08 PM, Tom Lane [EMAIL PROTECTED] wrote: Zdenek Kotala [EMAIL PROTECTED] writes: Attached patch allows to setup storage parameter for space reservation. What is the point of this? That's my question. Why is this needed at all? -- Jonah H. Harris, Senior DBA