Re: [HACKERS] WIP patch: collation assignment algorithm rewrite

2011-03-20 Thread Tom Lane
Martijn van Oosterhout writes: > I've looked over the main code and it looks good. While I'm not totally > conviced it has to be done as a seperate pass, this way is exceedingly > readable and clear as to what is going on, which makes me much more > confident of its correctness. FWIW, I'm not at

Re: [HACKERS] WIP patch: collation assignment algorithm rewrite

2011-03-20 Thread Martijn van Oosterhout
On Sat, Mar 19, 2011 at 05:22:39PM -0400, Tom Lane wrote: > Attached is a WIP patch to split the expression-tree representation of > collations into separate fields for input and output collation, and to > replace the parser's current method of assigning collations with a > recursive post-pass. I