Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-19 Thread Dean Rasheed
On 18 July 2013 22:27, Stephen Frost wrote: > Dean, > > > * Stephen Frost (sfr...@snowman.net) wrote: >> Thanks! This is really looking quite good, but it's a bit late and I'm >> going on vacation tomorrow, so I didn't quite want to commit it yet. :) > > Apologies on this taking a bit longer than

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-18 Thread Stephen Frost
Dean, * Stephen Frost (sfr...@snowman.net) wrote: > Thanks! This is really looking quite good, but it's a bit late and I'm > going on vacation tomorrow, so I didn't quite want to commit it yet. :) Apologies on this taking a bit longer than I expected, but it's been committed and pushed now. Pl

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-05 Thread Dean Rasheed
On 5 July 2013 07:02, Pavel Stehule wrote: > Hello > > I try to check this patch > > I have a problem with initdb after patching > > error > > initializing dependencies ... ok > creating system views ... FATAL: WITH CHECK OPTION is supported only > on auto-updatable views > STATEMENT: /* > > > I

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-05 Thread Pavel Stehule
Hello just some notes: * autocomplete for INSERT, UPDATE, DELETE should to show updatable views too * can you explain better in doc differences between WITH CASCADED or WITH LOCAL OPTION - assign some simple example to doc, please * is possible to better identify (describe) failed constraints?

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-06-21 Thread Stephen Frost
Dean, * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > Here's an updated version --- I missed the necessary update to the > check_option column of information_schema.views. Thanks! This is really looking quite good, but it's a bit late and I'm going on vacation tomorrow, so I didn't quite want

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-06-13 Thread Dean Rasheed
On 9 June 2013 11:14, Dean Rasheed wrote: > Here's a rebased version of the patch implementing WITH CHECK OPTION > for auto-updatable views. > > It now includes documentation, and a clearer description of the > patch's limitations --- WITH CHECK OPTION is only supported on > auto-updatable views,