Re: [HACKERS] Walker/mutator prototype.

2003-12-14 Thread Kurt Roeckx
On Sat, Dec 13, 2003 at 10:24:23PM -0500, Greg Stark wrote: Kurt Roeckx [EMAIL PROTECTED] writes: I'm trying to change all the walkers and mutators to have a more strict prototype. I had to do this with lots of casts. I don't really like the idea of having all those generic pointer

Re: [HACKERS] Walker/mutator prototype.

2003-12-14 Thread Greg Stark
Kurt Roeckx [EMAIL PROTECTED] writes: I did start by changing all the context's to void *, but you'll loose the real type that it gets called with, so the other calls will not generate warnings anymore because of wrong type. But at least you'll get a warning if someone passes a non-pointer

Re: [HACKERS] Walker/mutator prototype.

2003-12-14 Thread Tom Lane
Kurt Roeckx [EMAIL PROTECTED] writes: I'm trying to change all the walkers and mutators to have a more strict prototype. I had to do this with lots of casts. Forget it ;-). There's a reason why they use a loose prototype, and it's exactly what you just found: the notational penalty of being

Re: [HACKERS] Walker/mutator prototype.

2003-12-14 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: Kurt Roeckx [EMAIL PROTECTED] writes: I did start by changing all the context's to void *, but you'll loose the real type that it gets called with, so the other calls will not generate warnings anymore because of wrong type. But at least you'll get a

Re: [HACKERS] Walker/mutator prototype.

2003-12-13 Thread Greg Stark
Kurt Roeckx [EMAIL PROTECTED] writes: I'm trying to change all the walkers and mutators to have a more strict prototype. I had to do this with lots of casts. I don't really like the idea of having all those generic pointer types (Node * and void *), but currently see no better way to deal

[HACKERS] Walker/mutator prototype.

2003-12-12 Thread Kurt Roeckx
I'm trying to change all the walkers and mutators to have a more strict prototype. I had to do this with lots of casts. I don't really like the idea of having all those generic pointer types (Node * and void *), but currently see no better way to deal with it. I attached the patch. Kurt