Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-18 Thread Andrew Dunstan
On 01/18/2011 04:40 AM, Pavel Golub wrote: AD> We could add -Wno-format to the flags. That makes it shut up, but maybe AD> we don't want to use such a sledgehammer. I want to understand the only thing. Are these warnings really dangerous? Or I should just ignore them? As I pointed out

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-18 Thread Pavel Golub
Hello, Andrew. You wrote: AD> On 01/17/2011 03:51 PM, Tom Lane wrote: >> Andrew Dunstan writes: >>> On 01/17/2011 07:18 AM, Pavel Golub wrote: So you think I should just ignore these warnings? Because I can't remember the same behaviour on 8.x branches... >>> We've had them all along

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Andrew Dunstan
On 01/17/2011 03:51 PM, Tom Lane wrote: Andrew Dunstan writes: On 01/17/2011 07:18 AM, Pavel Golub wrote: So you think I should just ignore these warnings? Because I can't remember the same behaviour on 8.x branches... We've had them all along, as I said. See

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Tom Lane
Andrew Dunstan writes: > On 01/17/2011 07:18 AM, Pavel Golub wrote: >> So you think I should just ignore these warnings? Because I can't >> remember the same behaviour on 8.x branches... > We've had them all along, as I said. See >

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Tom Lane
Robert Haas writes: > 2011/1/13 Pavel Golub : >> pg_dump.c: In function 'dumpSequence': >> pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format >> pg_dump.c:11449:2: warning: too many arguments for format > It seems like PGAC_FUNC_SNPRINTF_LONG_LONG_INT_FORMAT is getting th

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Andrew Dunstan
On 01/17/2011 07:18 AM, Pavel Golub wrote: AD> Mingw has always had a huge number of format warnings. See for example AD> So you think I should just ignore these warnings? Because I ca

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Robert Haas
On Mon, Jan 17, 2011 at 5:54 AM, Pavel Golub wrote: > RH> It seems like PGAC_FUNC_SNPRINTF_LONG_LONG_INT_FORMAT is getting the > RH> wrong answer on your machine, though I'm not sure why.  The easiest > RH> workaround is probably to run configure and then edit > RH> src/include/pg_config.h before

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Pavel Golub
Hello, Andrew. You wrote: AD> On 01/17/2011 05:54 AM, Pavel Golub wrote: >> Hello, Robert. >> >> You wrote: >> >> RH> 2011/1/13 Pavel Golub: Hello, Pgsql-hackers. I'm getting such warnings: pg_dump.c: In function 'dumpSequence': pg_dump.c:11449:2: warning: unknown

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Andrew Dunstan
On 01/17/2011 05:54 AM, Pavel Golub wrote: Hello, Robert. You wrote: RH> 2011/1/13 Pavel Golub: Hello, Pgsql-hackers. I'm getting such warnings: pg_dump.c: In function 'dumpSequence': pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format pg_dump.c:11449:2: warning: t

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-17 Thread Pavel Golub
Hello, Robert. You wrote: RH> 2011/1/13 Pavel Golub : >> Hello, Pgsql-hackers. >> >> I'm getting such warnings: >> >> pg_dump.c: In function 'dumpSequence': >> pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format >> pg_dump.c:11449:2: warning: too many arguments for format

Re: [HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-16 Thread Robert Haas
2011/1/13 Pavel Golub : > Hello, Pgsql-hackers. > > I'm getting such warnings: > > pg_dump.c: In function 'dumpSequence': > pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format > pg_dump.c:11449:2: warning: too many arguments for format > pg_dump.c:11450:2: warning: unknown c

[HACKERS] Warning compiling pg_dump (MinGW, Windows XP)

2011-01-13 Thread Pavel Golub
Hello, Pgsql-hackers. I'm getting such warnings: pg_dump.c: In function 'dumpSequence': pg_dump.c:11449:2: warning: unknown conversion type character 'l' in format pg_dump.c:11449:2: warning: too many arguments for format pg_dump.c:11450:2: warning: unknown conversion type character 'l' in format