Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Tom Lane
I wrote: > Basically I think we have to fix this by ensuring that an error escape > can't occur while a relcache entry is in a partially rebuilt state. Attached is a draft patch for this. In addition to fixing the stated problem, it also takes care of a thinko that I found along the way: Relation

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 20:01 -0500, Tom Lane wrote: > I mentioned earlier that buildfarm member jaguar (that's the one that > builds with CLOBBER_CACHE_ALWAYS) was showing suspicious intermittent > failures. There's another one today: > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguar&

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Stefan Kaltenbrunner
Tom Lane wrote: I mentioned earlier that buildfarm member jaguar (that's the one that builds with CLOBBER_CACHE_ALWAYS) was showing suspicious intermittent failures. There's another one today: hmm I was just doing a CLOBBER_CACHE_ALWAYS build on one of my ARM based boxes and it seems to fall

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-08 Thread Tom Lane
Greg Stark writes: > How old is this problem? It doesn't sound like a backpatchable fix... Presumably it goes back to 8.0. I was planning to defer thinking about whether to back-patch it until we had a working fix and could see how big a change it really is. regards, tom

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-08 Thread Greg Stark
On Sat, Jan 9, 2010 at 1:01 AM, Tom Lane wrote: > Comments? > How old is this problem? It doesn't sound like a backpatchable fix... -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hack

[HACKERS] We need to rethink relation cache entry rebuild

2010-01-08 Thread Tom Lane
I mentioned earlier that buildfarm member jaguar (that's the one that builds with CLOBBER_CACHE_ALWAYS) was showing suspicious intermittent failures. There's another one today: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jaguar&dt=2010-01-08%2004:00:02 and I also managed to reproduce a