On Wed, 2008-05-14 at 20:25 +0100, Gregory Stark wrote:
> The Linux kernel does have some macros meant to mark unlikely branches
> (usually assertion failures) but I'm not sure how they work. And Gcc also has
> a few optimizations which are driven by profiling data but I it doesn't sound
> like thi
On Wed, May 14, 2008 at 08:25:10PM +0100, Gregory Stark wrote:
> The Linux kernel does have some macros meant to mark unlikely branches
> (usually assertion failures) but I'm not sure how they work. And Gcc also has
> a few optimizations which are driven by profiling data but I it doesn't sound
> l
Gregory Stark <[EMAIL PROTECTED]> writes:
> Fwiw, these two call sites are only for when HeapTupleSatisfiesMVCC finds a
> tuples which has been moved away by VACUUM FULL... The latter for when it
> finds such a tuple but the VACUUM FULL aborted.
> It seems quite likely that the compiler is actuall
"Martijn van Oosterhout" <[EMAIL PROTECTED]> writes:
> On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
>> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’:
>> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is
>> > unlikely and code size would grow
>> > tqua
"Martijn van Oosterhout" <[EMAIL PROTECTED]> writes:
> On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
>> > tqual.c: In function ‘HeapTupleSatisfiesVacuum’:
>> > tqual.c:88: error: inlining failed in call to ‘SetHintBits’: call is
>> > unlikely and code size would grow
>> > tqua
On Wed, May 14, 2008 at 12:45:49PM -0400, Tom Lane wrote:
> > tqual.c: In function âHeapTupleSatisfiesVacuumâ:
> > tqual.c:88: error: inlining failed in call to âSetHintBitsâ: call is
> > unlikely and code size would grow
> > tqual.c:1057: error: called from here
> > tqual.c:88: error: inl
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> What do we do with warnings generated by -Winline?
I believe we just put that in to see how many places inlining was being
done or not. If you want to compile with -Werror you'd better take it out.
> tqual.c: In function âHeapTupleSatisfiesVacuumâ
What do we do with warnings generated by -Winline?
I see this now:
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline
-Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -fwrapv -g
-Werror -I../../../../src/include -D_GNU_SOURCE -I/usr/include/libxml2 -c -o
tuplesort.o
