[HACKERS] Why does pg_ctl.c have its own copy of PM_VERSIONSTR?

2008-02-20 Thread Tom Lane
Why isn't pg_ctl.c using PG_VERSIONSTR from miscadmin.h? Seems like this is something that will have to be kept in sync manually (I see from the CVS logs that Peter already had to do that once). If the feeling is that miscadmin.h is a backend include file that shouldn't be used by pg_ctl (which

Re: [HACKERS] Why does pg_ctl.c have its own copy of PM_VERSIONSTR?

2008-02-20 Thread Andrew Dunstan
Tom Lane wrote: Why isn't pg_ctl.c using PG_VERSIONSTR from miscadmin.h? Seems like this is something that will have to be kept in sync manually (I see from the CVS logs that Peter already had to do that once). If the feeling is that miscadmin.h is a backend include file that shouldn't be

Re: [HACKERS] Why does pg_ctl.c have its own copy of PM_VERSIONSTR?

2008-02-20 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Tom Lane wrote: Why isn't pg_ctl.c using PG_VERSIONSTR from miscadmin.h? It looks like I adapted it from initdb.c - that would make sense given the time frames. Oh, I hadn't seen the one in initdb.c. That's just plain silly, seeing that it's