Tom Lane [EMAIL PROTECTED] дÈëÓʼþ
news:[EMAIL PROTECTED]
Jacky Leng [EMAIL PROTECTED] writes:
Cann't we remove this param?
No.
We can rewrite like this:
1.XLogReadBuffer:
* remove init;
* everytime we cann't read a block, just log_invalid_page it, and
return
InvalidBuffer;
Oh, I am wrong!
Jacky Leng [EMAIL PROTECTED] дÈëÓʼþ
news:[EMAIL PROTECTED]
Tom Lane [EMAIL PROTECTED] дÈëÓʼþ
news:[EMAIL PROTECTED]
Jacky Leng [EMAIL PROTECTED] writes:
Cann't we remove this param?
No.
We can rewrite like this:
1.XLogReadBuffer:
* remove init;
*
Cann't we remove this param?
We can rewrite like this:
1.XLogReadBuffer:
* remove init;
* everytime we cann't read a block, just log_invalid_page it, and return
InvalidBuffer;
2.Also rewrite all functions calling XLogReadBuffer with init=true: skip
current block if XLogReadBuffer return
Jacky Leng [EMAIL PROTECTED] writes:
Cann't we remove this param?
No.
We can rewrite like this:
1.XLogReadBuffer:
* remove init;
* everytime we cann't read a block, just log_invalid_page it, and return
InvalidBuffer;
Your proposal degrades the robustness of the system by turning
