On Mon, Jan 26, 2015 at 9:52 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Tue, Jan 27, 2015 at 4:21 AM, Robert Haas robertmh...@gmail.com wrote:
That's what I hope to find out. :-)
Buildfarm seems happy now. I just gave a try to that on one of my
small Windows VMs and compared the
On Mon, Jan 26, 2015 at 2:10 PM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Jan 26, 2015 at 11:05 AM, Robert Haas robertmh...@gmail.com wrote:
Now that these issues are fixed and the buildfarm is green again, I'm
going to try re-enabling this optimization on Windows. My working
theory is
On Fri, Jan 23, 2015 at 12:34 PM, Robert Haas robertmh...@gmail.com wrote:
In other words, even on systems that don't HAVE_LOCALE_T, we still
have to support the default collation and the C collation, and they
have to behave differently. There's no way to make that work using
only strxfrm(),
On Mon, Jan 26, 2015 at 11:05 AM, Robert Haas robertmh...@gmail.com wrote:
Now that these issues are fixed and the buildfarm is green again, I'm
going to try re-enabling this optimization on Windows. My working
theory is that disabling that categorically was a mis-diagnosis of the
real
On Tue, Jan 27, 2015 at 4:21 AM, Robert Haas robertmh...@gmail.com wrote:
That's what I hope to find out. :-)
Buildfarm seems happy now. I just gave a try to that on one of my
small Windows VMs and compared the performance with 9.4 for this
simple test case when building with MSVC 2010:
create
On Thu, Jan 22, 2015 at 5:51 PM, Peter Geoghegan p...@heroku.com wrote:
That having been said, it's clearer to continue to handle each case (C
locale vs other locales) separately within the new
bttext_abbrev_convert() function, just to be consistent, but also to
avoid NUL-terminating the text
On Thu, Jan 22, 2015 at 10:57 AM, Robert Haas robertmh...@gmail.com wrote:
On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan p...@heroku.com wrote:
Even following Robert's disabling of abbreviated keys on Windows,
buildfarm animals hamerkop, brolga, currawong and bowerbird remain
unhappy, with
On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan p...@heroku.com wrote:
Even following Robert's disabling of abbreviated keys on Windows,
buildfarm animals hamerkop, brolga, currawong and bowerbird remain
unhappy, with failing regression tests for collate and sometimes
(but not always)
On Thu, Jan 22, 2015 at 12:34 PM, Robert Haas robertmh...@gmail.com wrote:
This isn't really Windows-specific. The root of the problem is that
when LC_COLLATE=C you were trying to use strxfrm() for the abbreviated
key even though memcmp() is the authoritative comparator in that case.
Exactly
On Thu, Jan 22, 2015 at 11:28 AM, Robert Haas robertmh...@gmail.com wrote:
This seems to have broken more stuff. My working hypothesis is that
the culprit is here:
/*
* There is no special handling of the C locale here, unlike with
* varstr_cmp(). strxfrm() is
On Thu, Jan 22, 2015 at 1:00 PM, Peter Geoghegan p...@heroku.com wrote:
On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas robertmh...@gmail.com wrote:
Stay tuned for more exciting dispatches from the department of abbreviated
keys!
I certainly suspected that we'd have problems with Windows, but
On Thu, Jan 22, 2015 at 12:17 PM, Robert Haas robertmh...@gmail.com wrote:
Long story short: this was broken. It may be that when the dust
settles we can try re-enabling this on Windows. It might work now
that this issue is (hopefully) fixed.
Uggh. That still wasn't right; I've pushed
On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas robertmh...@gmail.com wrote:
Stay tuned for more exciting dispatches from the department of abbreviated
keys!
I certainly suspected that we'd have problems with Windows, but
nothing this bad.
--
Peter Geoghegan
--
Sent via pgsql-hackers mailing
Even following Robert's disabling of abbreviated keys on Windows,
buildfarm animals hamerkop, brolga, currawong and bowerbird remain
unhappy, with failing regression tests for collate and sometimes
(but not always) aggregates. Some of these only use the C locale.
I think that aggregates does not
14 matches
Mail list logo
