Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-22 Thread Andrew Gierth
> "Albe" == Albe Laurenz writes: Albe> I *guess* it is the problem addressed by Albe> http://archives.postgresql.org/pgsql-committers/2008-04/msg00275.php Albe> and Albe> http://archives.postgresql.org/pgsql-committers/2008-04/msg00358.php No; the problem is with stop -mimmediate (not -

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-22 Thread Albe Laurenz
Tom Lane wrote: >> I propose that this behaviour be changed such that 'terse' is ignored >> for all log messages of FATAL or PANIC severity. >> [ on the strength of a single example ] > [...] > > It seems like it might be better to rephrase error messages to ensure > that anything really critical

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-21 Thread Andrew Gierth
> "Alvaro" == Alvaro Herrera writes: Alvaro> Is errdetail not printed when verbosity = terse? No, it's not. -- Andrew. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-21 Thread Andrew Gierth
> "Tom" == Tom Lane writes: >> I propose that this behaviour be changed such that 'terse' is >> ignored for all log messages of FATAL or PANIC severity. >> [ on the strength of a single example ] Tom> This seems like using a blunderbuss where a rifle is called for. Maybe so. Tom> Ther

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-20 Thread Alvaro Herrera
Tom Lane wrote: > It seems like it might be better to rephrase error messages to ensure > that anything really critical is mentioned in the primary message. > In this case, perhaps instead of > errmsg("could not locate required checkpoint record") > we could have it print > errmsg("cou

Re: [HACKERS] a small proposal for avoiding foot-shooting

2008-12-20 Thread Tom Lane
Andrew Gierth writes: > I propose that this behaviour be changed such that 'terse' is ignored > for all log messages of FATAL or PANIC severity. > [ on the strength of a single example ] This seems like using a blunderbuss where a rifle is called for. There may indeed be some places where we hav

[HACKERS] a small proposal for avoiding foot-shooting

2008-12-20 Thread Andrew Gierth
Currently setting "log_error_verbosity = terse" causes all HINT output to the log file to be suppressed (along with some other stuff). I propose that this behaviour be changed such that 'terse' is ignored for all log messages of FATAL or PANIC severity. The main reason for this is messages like (