Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-25 Thread Magnus Hagander
On Tue, May 24, 2011 at 22:31, Jaime Casanova wrote: > On Tue, May 24, 2011 at 8:52 PM, Fujii Masao wrote: > >> +       primary_xlp_magic = atoi(PQgetvalue(res, 0, 2)); >> >> You wrongly get the third field (i.e., current xlog location) as the >> WAL version. >> You should call PQgetvalue(res, 0,

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-24 Thread Jaime Casanova
On Tue, May 24, 2011 at 8:52 PM, Fujii Masao wrote: > +       primary_xlp_magic = atoi(PQgetvalue(res, 0, 2)); > > You wrongly get the third field (i.e., current xlog location) as the > WAL version. > You should call PQgetvalue(res, 0, 3), instead. > >> errdetail("Expected 1 tuple with 3 fields,

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-24 Thread Fujii Masao
On Wed, May 25, 2011 at 8:26 AM, Jaime Casanova wrote: > On Fri, May 20, 2011 at 12:50 PM, Magnus Hagander wrote: >> >> Yes. It might be useful to note it, and then ust make an override >> flag. My pointm, though, was that doing it for walreceiver is more >> important and a more logical first ste

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-24 Thread Jaime Casanova
On Fri, May 20, 2011 at 12:50 PM, Magnus Hagander wrote: > > Yes. It might be useful to note it, and then ust make an override > flag. My pointm, though, was that doing it for walreceiver is more > important and a more logical first step. > ok, patch attached. -- Jaime Casanova         www.2ndQ

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-20 Thread Magnus Hagander
On Tue, May 17, 2011 at 16:38, Jaime Casanova wrote: > On Mon, May 16, 2011 at 2:35 AM, Magnus Hagander wrote: >> On Mon, May 16, 2011 at 01:03, Jaime Casanova wrote: >>> On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: Magnus Hagander writes: >> So even if people don't believe in the

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-17 Thread Jaime Casanova
On Mon, May 16, 2011 at 2:35 AM, Magnus Hagander wrote: > On Mon, May 16, 2011 at 01:03, Jaime Casanova wrote: >> On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: >>> Magnus Hagander writes: > So even if people don't believe in the rationale behind the patch, > would allowing it harm an

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-16 Thread Magnus Hagander
On Mon, May 16, 2011 at 01:03, Jaime Casanova wrote: > On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: >> Magnus Hagander writes: So even if people don't believe in the rationale behind the patch, would allowing it harm anything at this point? >> >>> Adding it for the sake of upgrades

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-15 Thread Jaime Casanova
On Sun, May 15, 2011 at 6:03 PM, Jaime Casanova wrote: > On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: >> Magnus Hagander writes: So even if people don't believe in the rationale behind the patch, would allowing it harm anything at this point? >> >>> Adding it for the sake of upgrad

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-15 Thread Jaime Casanova
On Thu, May 5, 2011 at 10:59 AM, Tom Lane wrote: > Magnus Hagander writes: >>> So even if people don't believe in the rationale behind the patch, >>> would allowing it harm anything at this point? > >> Adding it for the sake of upgrades seems very far fetched. > >> Adding it for the sake of givin

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-05 Thread Tom Lane
Magnus Hagander writes: >> So even if people don't believe in the rationale behind the patch, >> would allowing it harm anything at this point? > Adding it for the sake of upgrades seems very far fetched. > Adding it for the sake of giving a better error message seems like a > very good idea. Bu

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-05 Thread Magnus Hagander
On Wed, May 4, 2011 at 22:42, Simon Riggs wrote: > On Wed, May 4, 2011 at 3:47 AM, Tom Lane wrote: >> Jaime Casanova writes: >>> I want to propose the addition of a new field in IDENTIFY_SYSTEM: >>> xlogversion, which will carry XLOG_PAGE_MAGIC from primary. >>> The idea of sending that info is

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-04 Thread Simon Riggs
On Wed, May 4, 2011 at 3:47 AM, Tom Lane wrote: > Jaime Casanova writes: >> I want to propose the addition of a new field in IDENTIFY_SYSTEM: >> xlogversion, which will carry XLOG_PAGE_MAGIC from primary. >> The idea of sending that info is to allow us to know if the xlog page >> version of two d

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-03 Thread Tom Lane
Jaime Casanova writes: > I want to propose the addition of a new field in IDENTIFY_SYSTEM: > xlogversion, which will carry XLOG_PAGE_MAGIC from primary. > The idea of sending that info is to allow us to know if the xlog page > version of two different major versions are compatible or not. > Curren

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-03 Thread Jaime Casanova
On Tue, May 3, 2011 at 6:32 PM, Andres Freund wrote: > > I can't see xlog replication working between major versions. well, probably... but not many years ago we wouldn't see integrated replication in postgresql... still, here we are... it's a difficult problem to solve? surely. we can make it wo

Re: [HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-03 Thread Andres Freund
Hi, On Wednesday, May 04, 2011 12:39:49 AM Jaime Casanova wrote: > I want to propose the addition of a new field in IDENTIFY_SYSTEM: > xlogversion, which will carry XLOG_PAGE_MAGIC from primary. > The idea of sending that info is to allow us to know if the xlog page > version of two different majo

[HACKERS] adding a new column in IDENTIFY_SYSTEM

2011-05-03 Thread Jaime Casanova
Hi I want to propose the addition of a new field in IDENTIFY_SYSTEM: xlogversion, which will carry XLOG_PAGE_MAGIC from primary. The idea of sending that info is to allow us to know if the xlog page version of two different major versions are compatible or not. Currently pg_upgrade requires the pr