Re: [HACKERS] auto_explain log_verbose causes regression failure

2010-02-23 Thread Bruce Momjian
Uh, I don't see this patch as applied. Was it not necessary? --- Itagaki Takahiro wrote: Robert Haas robertmh...@gmail.com wrote: It looks like this is enough to reproduce the cache lookup failure: The cache

Re: [HACKERS] auto_explain log_verbose causes regression failure

2010-02-23 Thread Takahiro Itagaki
Bruce Momjian br...@momjian.us wrote: Uh, I don't see this patch as applied. Was it not necessary? No, the bug was reported again and fixed then with: - Force READY portals into FAILED state when a transaction or subtransaction is aborted Message-Id:

Re: [HACKERS] auto_explain log_verbose causes regression failure

2010-02-23 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Uh, I don't see this patch as applied. Was it not necessary? It was not; the real problem was that ExecutorEnd shouldn't have been called at all, which I fixed in the portal code. regards, tom lane -- Sent via pgsql-hackers

Re: [HACKERS] auto_explain log_verbose causes regression failure

2010-02-23 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Uh, I don't see this patch as applied. Was it not necessary? It was not; the real problem was that ExecutorEnd shouldn't have been called at all, which I fixed in the portal code. Thanks, both of you. :-) -- Bruce Momjian

[HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Andrew Dunstan
I am getting a repeatable failure on the HEAD regression tests when auto_explain's log_verbose is set. If auto_explain.log_verbose is turned off the failure disappears. Data below. cheers andrew config settings: custom_variable_classes = 'auto_explain' auto_explain.log_min_duration = 0

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Robert Haas
On Wed, Aug 19, 2009 at 7:57 PM, Andrew Dunstanandrew.duns...@pgexperts.com wrot I am getting a repeatable failure  on the HEAD regression tests when auto_explain's log_verbose is set. If auto_explain.log_verbose is turned off the failure disappears. Data below. cheers andrew config

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Andrew Dunstan
Robert Haas wrote: On Wed, Aug 19, 2009 at 7:57 PM, Andrew Dunstanandrew.duns...@pgexperts.com wrot I am getting a repeatable failure on the HEAD regression tests when auto_explain's log_verbose is set. If auto_explain.log_verbose is turned off the failure disappears. Data below. cheers

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Robert Haas
On Wed, Aug 19, 2009 at 9:39 PM, Andrew Dunstanand...@dunslane.net wrote: Robert Haas wrote: On Wed, Aug 19, 2009 at 7:57 PM, Andrew Dunstanandrew.duns...@pgexperts.com wrot I am getting a repeatable failure  on the HEAD regression tests when auto_explain's log_verbose is set. If

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Robert Haas
On Wed, Aug 19, 2009 at 10:07 PM, Robert Haasrobertmh...@gmail.com wrote: On Wed, Aug 19, 2009 at 9:39 PM, Andrew Dunstanand...@dunslane.net wrote: Robert Haas wrote: On Wed, Aug 19, 2009 at 7:57 PM, Andrew Dunstanandrew.duns...@pgexperts.com wrot I am getting a repeatable failure  on the

Re: [HACKERS] auto_explain log_verbose causes regression failure

2009-08-19 Thread Itagaki Takahiro
Robert Haas robertmh...@gmail.com wrote: It looks like this is enough to reproduce the cache lookup failure: The cache loopup failure part could be fixed by the attached patch. It forbids explaining if the transaction is in error state. I cannot reproduce unexpected refassgnexpr and