Re: [HACKERS] buffer locking fix for lazy_scan_heap

2015-08-03 Thread Robert Haas
On Mon, Aug 3, 2015 at 12:03 AM, 高增琦 wrote: > sorry for asking this really old commit. > > http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7ab9b2f3b79177e501a1ef90ed004cc68788abaf > > I could not understand why "releases the lock on the buffer" is > a problem since vacuum will lo

Re: [HACKERS] buffer locking fix for lazy_scan_heap

2015-08-02 Thread 高增琦
Hi, sorry for asking this really old commit. http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7ab9b2f3b79177e501a1ef90ed004cc68788abaf I could not understand why "releases the lock on the buffer" is a problem since vacuum will lock and check the page bit again before set the vm.

[HACKERS] buffer locking fix for lazy_scan_heap

2012-04-18 Thread Robert Haas
I discovered when researching the issue of index-only scans and Hot Standby that there's a bug (for which I'm responsible) in lazy_scan_heap[1]. Actually, the code has been like this for a long time, but I needed to change it when I did the crash-safe visibility map work, and I didn't. The proble