Re: [HACKERS] cache lookup errors for missing replication origins

2017-10-05 Thread Michael Paquier
On Thu, Oct 5, 2017 at 9:38 PM, Robert Haas wrote: > On Tue, Oct 3, 2017 at 2:16 AM, Masahiko Sawada wrote: >> The patch passes the regression test and I found no problems in this >> patch. I've marked it as Ready for Committer. > > Committed and

Re: [HACKERS] cache lookup errors for missing replication origins

2017-10-05 Thread Robert Haas
On Tue, Oct 3, 2017 at 2:16 AM, Masahiko Sawada wrote: > The patch passes the regression test and I found no problems in this > patch. I've marked it as Ready for Committer. Committed and back-patched to 9.5, which was as far as it applied cleanly. -- Robert Haas

Re: [HACKERS] cache lookup errors for missing replication origins

2017-10-03 Thread Masahiko Sawada
On Wed, Sep 6, 2017 at 3:51 PM, Michael Paquier wrote: > On Tue, Sep 5, 2017 at 12:59 PM, Michael Paquier > wrote: >> ERROR: 42704: replication slot "%s" does not exist > > s/slot/origin/ > >> As far as I can see, replorigin_by_oid makes no

Re: [HACKERS] cache lookup errors for missing replication origins

2017-09-06 Thread Michael Paquier
On Tue, Sep 5, 2017 at 12:59 PM, Michael Paquier wrote: > ERROR: 42704: replication slot "%s" does not exist s/slot/origin/ > As far as I can see, replorigin_by_oid makes no use of its missing_ok > = false in the backend code, so letting it untouched would have no >

[HACKERS] cache lookup errors for missing replication origins

2017-09-04 Thread Michael Paquier
Hi all, Cache lookup errors with elog() can be triggered easily by users at SQL level using replication origin functions: =# select pg_replication_origin_advance('popo', '0/1'); ERROR: XX000: cache lookup failed for replication origin 'popo' LOCATION: replorigin_by_name, origin.c:229 =# select