Re: [HACKERS] code cleanup empty string initializations

2017-09-08 Thread Peter Eisentraut
On 9/8/17 03:45, Aleksandr Parfenov wrote: > The following review has been posted through the commitfest application: > make installcheck-world: tested, passed > Implements feature: tested, passed > Spec compliant: tested, passed > Documentation:tested, passed > > Hi P

Re: [HACKERS] code cleanup empty string initializations

2017-09-08 Thread Aleksandr Parfenov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed Hi Peter, I looked through your patches and its look good to

[HACKERS] code cleanup empty string initializations

2017-08-30 Thread Peter Eisentraut
In initdb, many global string variables are initialized as empty strings ("") and then checked later with strcmp(), instead of just using NULL. I think this is probably left over from the shell script conversion. The style has also spread to pg_basebackup. So here is a patch to clean that up, and