Re: [HACKERS] code cleanup for SearchSysCache

2006-06-08 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > "Tom Lane" <[EMAIL PROTECTED]> wrote >> You'd need two essentially equivalent versions of SearchSysCache, and >> you'd lose the ability to make the error message identify what was being >> searched for, so I vote no. > Both arguments are not necessaril

Re: [HACKERS] code cleanup for SearchSysCache

2006-06-08 Thread Qingqing Zhou
"Tom Lane" <[EMAIL PROTECTED]> wrote > > You'd need two essentially equivalent versions of SearchSysCache, and > you'd lose the ability to make the error message identify what was being > searched for, so I vote no. > Both arguments are not necessarily true. This change is quite like what we made

Re: [HACKERS] code cleanup for SearchSysCache

2006-06-08 Thread Tom Lane
"Qingqing Zhou" <[EMAIL PROTECTED]> writes: > There are roughly 420 calls of SearchSysCache() and 217 of which are just > report "cache lookup failed". Shall we put the elog in the SearchSysCache > itself? You'd need two essentially equivalent versions of SearchSysCache, and you'd lose the ability

[HACKERS] code cleanup for SearchSysCache

2006-06-07 Thread Qingqing Zhou
There are roughly 420 calls of SearchSysCache() and 217 of which are just report "cache lookup failed". Shall we put the elog in the SearchSysCache itself? Notice that most search is on the "Oid" field -- which is *not* user visible, so I think most of them can safely let SearchSysCache handle the