[HACKERS] Compile warning

2008-04-04 Thread Bruce Momjian
Magnus, I am seeing this compile warning, I think related to work you were doing: guc.c:7116: warning: `assign_backslash_quote' defined but not used -- Bruce Momjian [EMAIL PROTECTED]http://momjian.us EnterpriseDB http://enterprisedb.com + If your

Re: [HACKERS] Compile warning

2008-04-04 Thread Magnus Hagander
Bruce Momjian wrote: Magnus, I am seeing this compile warning, I think related to work you were doing: guc.c:7116: warning: `assign_backslash_quote' defined but not used Yup, that's mine, fixed. //Magnus -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] compile warning in CVS HEAD

2004-03-18 Thread Neil Conway
I get the following warning compiling CVS HEAD: [neilc:/Users/neilc/pgsql]% make -C src/backend/utils/error all [ ... ] gcc -no-cpp-precomp -O0 -Winline -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../../src/include -I/sw/include -c -o elog.o elog.c -MMD

Re: [HACKERS] compile warning in CVS HEAD

2004-03-18 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: I get the following warning compiling CVS HEAD: [neilc:/Users/neilc/pgsql]% make -C src/backend/utils/error all [ ... ] gcc -no-cpp-precomp -O0 -Winline -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../../../src/include

Re: [HACKERS] compile warning in CVS HEAD

2004-03-18 Thread Andrew Dunstan
Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: I get the following warning compiling CVS HEAD: [neilc:/Users/neilc/pgsql]% make -C src/backend/utils/error all [ ... ] gcc -no-cpp-precomp -O0 -Winline -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations

Re: [HACKERS] compile warning in CVS HEAD

2004-03-18 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: *sigh* my local (linux) man for gettimeofday says this: struct timeval { time_t tv_sec;/* seconds */ suseconds_ttv_usec; /* microseconds */ }; Yeah, but mine (HPUX) says that tv_sec

Re: [HACKERS] compile warning

2003-10-11 Thread Andrew Dunstan
- Original Message - From: Andrew Dunstan [EMAIL PROTECTED] To: PostgreSQL Hackers Mailing List [EMAIL PROTECTED] Sent: Saturday, October 11, 2003 8:58 AM Subject: Re: [HACKERS] compile warning - Original Message - From: Manfred Spraul [EMAIL PROTECTED] The kernel is still

Re: [HACKERS] compile warning

2003-10-11 Thread Bruce Momjian
Andrew Dunstan wrote: I have a fix for this which I will post to patches - essentially you cast the pointers to (void *) and the compiler doesn't complain. It would be a pity to turn off strict aliasing altogether, as it is known to improve performance in some cases. Tested on Cygwin/GCC

Re: [HACKERS] compile warning

2003-10-11 Thread Andrew Dunstan
- Original Message - From: Bruce Momjian [EMAIL PROTECTED] To: Andrew Dunstan [EMAIL PROTECTED] Cc: PostgreSQL Hackers Mailing List [EMAIL PROTECTED] Sent: Saturday, October 11, 2003 11:26 AM Subject: Re: [HACKERS] compile warning Andrew Dunstan wrote: I have a fix for this which

Re: [HACKERS] compile warning

2003-10-11 Thread Bruce Momjian
- From: Bruce Momjian [EMAIL PROTECTED] To: Andrew Dunstan [EMAIL PROTECTED] Cc: PostgreSQL Hackers Mailing List [EMAIL PROTECTED] Sent: Saturday, October 11, 2003 11:26 AM Subject: Re: [HACKERS] compile warning Andrew Dunstan wrote: I have a fix for this which I will post

Re: [HACKERS] compile warning

2003-10-11 Thread Alvaro Herrera
On Sat, Oct 11, 2003 at 12:17:42PM -0400, Andrew Dunstan wrote: If you don't want to do this we could turn off strict-aliasing. You might take a performance hit, though - see http://www.freetype.org/pipermail/devel/2003-June/009452.html for info on what the FreeType people found. See the

Re: [HACKERS] compile warning

2003-10-10 Thread Bruce Momjian
Alvaro Herrera wrote: On Thu, Oct 09, 2003 at 11:51:09PM -0400, Bruce Momjian wrote: Alvaro Herrera wrote: I'm seeing this compile warning on today's CVS tip: $ make src/backend/commands/tablecmds.o gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -I./src/include

Re: [HACKERS] compile warning

2003-10-10 Thread Andrew Dunstan
Bruce Momjian wrote: This seems to be a bug in gcc-3.3.1. -fstrict-aliasing is enabled by -O2 or higher optimization in gcc 3.3.1. Now that I think of it, they might be talking about an optimization called register aliasing, where they are taking the structure and mapping it to a CPU register

Re: [HACKERS] compile warning

2003-10-10 Thread Manfred Spraul
Andrew Dunstan wrote: Bruce Momjian wrote: This seems to be a bug in gcc-3.3.1. -fstrict-aliasing is enabled by -O2 or higher optimization in gcc 3.3.1. According to the C standard, it's illegal to access a data with a pointer of the wrong type. The only exception is char *. This can be used

Re: [HACKERS] compile warning

2003-10-09 Thread Bruce Momjian
Alvaro Herrera wrote: I'm seeing this compile warning on today's CVS tip: $ make src/backend/commands/tablecmds.o gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -I./src/include -D_GNU_SOURCE -c -o src/backend/commands/tablecmds.o src/backend/commands/tablecmds.c

Re: [HACKERS] compile warning

2003-10-09 Thread Alvaro Herrera
On Thu, Oct 09, 2003 at 11:51:09PM -0400, Bruce Momjian wrote: Alvaro Herrera wrote: I'm seeing this compile warning on today's CVS tip: $ make src/backend/commands/tablecmds.o gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -I./src/include -D_GNU_SOURCE -c -o

[HACKERS] compile warning

2003-10-08 Thread Alvaro Herrera
I'm seeing this compile warning on today's CVS tip: $ make src/backend/commands/tablecmds.o gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -I./src/include -D_GNU_SOURCE -c -o src/backend/commands/tablecmds.o src/backend/commands/tablecmds.c src/backend/commands/tablecmds.c: In