Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Patrick Welche
On Mon, Sep 15, 2003 at 08:09:22PM +0200, Peter Eisentraut wrote: > Neil Conway writes: > > > On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: > > > > > tablecmds.c: In function `validateForeignKeyConstraint': > > > > > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > > > >

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Kurt Roeckx
On Mon, Sep 15, 2003 at 08:09:22PM +0200, Peter Eisentraut wrote: > Neil Conway writes: > > > On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: > > > > > tablecmds.c: In function `validateForeignKeyConstraint': > > > > > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > > > >

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Peter Eisentraut
Neil Conway writes: > On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: > > > > tablecmds.c: In function `validateForeignKeyConstraint': > > > > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > > > > strict-aliasing rules > > So, what should we do with this? Rumor has it th

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Neil Conway
On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: > > > tablecmds.c: In function `validateForeignKeyConstraint': > > > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > > > strict-aliasing rules So, what should we do with this? > The recommended way to deal with is to put th

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-04 Thread Kurt Roeckx
On Wed, Sep 03, 2003 at 10:30:05PM -0400, Tom Lane wrote: > > > tablecmds.c: In function `validateForeignKeyConstraint': > > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > > strict-aliasing rules > > Hm. Got any idea what these are really complaining about? I see no >

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I'm seeing the following with the current CVS code on my Linux dev box: > In file included from bootparse.y:340: > lex.Int_yy.c:1832: warning: no previous prototype for `Int_yyget_lineno' > lex.Int_yy.c:1841: warning: no previous prototype for `Int_yyget_i

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Bruce Momjian
Neil Conway wrote: > I'm seeing the following with the current CVS code on my Linux dev box: Gee, that's strange. I have never seen those errors before. > > $ make maintainer-clean > $ ./configure --enable-depend --enable-cassert --enable-debug > --prefix=/pgsql --with-openssl > [ ... ] > $ mak

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Peter Eisentraut
Neil Conway writes: > lex.Int_yy.c:1832: warning: no previous prototype for `Int_yyget_lineno' These are caused by the new flex. Ignore them. > tablecmds.c: In function `validateForeignKeyConstraint': > tablecmds.c:3546: warning: dereferencing type-punned pointer will break > strict-a

[HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Neil Conway
I'm seeing the following with the current CVS code on my Linux dev box: $ make maintainer-clean $ ./configure --enable-depend --enable-cassert --enable-debug --prefix=/pgsql --with-openssl [ ... ] $ make -s In file included from bootparse.y:340: lex.Int_yy.c:1832: warning: no previous prototype fo

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Tom Lane
I said: > Another alternative is > char *fmt = "%c"; > ... > strftime(..., fmt, ...); > which I think will probably defeat gcc's check (haven't tried it > though). I tried this, and it did shut up the warning in my local copy of gcc. So I committed it. > Does anyone want to arg

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
I have applied patches to the regression test to fix this. Thanks. --- Neil Conway wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > I get the following compiling the current CVS code with gcc 3.1: > > I also get 4 reg

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
Yes, very nanny-ish. Not sure how to turn it off. --- Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > pg_controldata.c: In function `main': > > pg_controldata.c:91: warning: `%c' yields only last 2 digits of

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
OK, I have fixed the first two with the following patch. The second pair Tom has commented on. --- Neil Conway wrote: > I get the following compiling the current CVS code with gcc 3.1: > > ... > fe-connect.c: In function

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > pg_controldata.c: In function `main': > pg_controldata.c:91: warning: `%c' yields only last 2 digits of year in some locales > pg_controldata.c:93: warning: `%c' yields only last 2 digits of year in some locales Yeah. I was willing to ignore that while p

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Neil Conway
Neil Conway <[EMAIL PROTECTED]> writes: > I get the following compiling the current CVS code with gcc 3.1: I also get 4 regression test failures, due to Gavin's improvements to the parser error messages. AFAICT no actual problems, the expected error message strings just needed to be updated. Che

[HACKERS] compile warnings in CVS

2002-08-17 Thread Neil Conway
I get the following compiling the current CVS code with gcc 3.1: ... fe-connect.c: In function `connectDBComplete': fe-connect.c:1081: warning: suggest parentheses around && within || fe-connect.c:1086: warning: implicit declaration of function `gettimeofday' ... pg_controldata.c: In function `ma