Re: [HACKERS] compile warnings in HEAD

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Philip Warner wrote: > At 12:57 AM 27/08/2004, Bruce Momjian wrote: > >Has this been fixed? > > In my local files, yes. I've been waiting on the 'set magic_tablespace' > code, but patch to fix

Re: [HACKERS] compile warnings in HEAD

2004-08-26 Thread Philip Warner
At 12:57 AM 27/08/2004, Bruce Momjian wrote: Has this been fixed? In my local files, yes. I've been waiting on the 'set magic_tablespace' code, but patch to fix the warnings only is attached. Philip Warner|

Re: [HACKERS] compile warnings in HEAD

2004-08-26 Thread Bruce Momjian
Has this been fixed? --- Neil Conway wrote: > I get the following warnings compiling current sources: > > /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function > `_isIdentChar': > /Users/neilc/pgsql/src/bin/pg_dum

Re: [HACKERS] compile warnings in HEAD

2004-08-23 Thread Philip Warner
At 12:11 PM 24/08/2004, Neil Conway wrote: I get the following warnings compiling current sources: My fault; I'll fix it in the next patch to pg_dump etc. I compare a char to the range \200 through \377. It must always be >= \200...at least I assume that's the problem. --

[HACKERS] compile warnings in HEAD

2004-08-23 Thread Neil Conway
I get the following warnings compiling current sources: /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function `_isIdentChar': /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c:874: warning: comparison is always true due to limited range of data type /Users/neilc/pgsql/src/bin/pg_dump/pg_